Don't deploy UI Plugin resources if the manifests are missing

[orenc1]

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What this PR does / why we need it:
If for whatever reason the UI manifests does not exist in the operator's filesystem, we don't want the operator to deploy UI-related resources, resulting in an error log.
Special notes for your reviewer:

Release note:

Don't deploy UI Plugin resources if the manifests are missing

[kubevirt-bot]

Hi @orenc1. Thanks for your PR.

I'm waiting for a nmstate member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[orenc1]

/ok-to-test

[kubevirt-bot]

@orenc1: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dougsland]

just a small question: should we notify users via log that ui-plugin is not installed ?

Example:

if "NMState version supports ui-plugin" && "messageNotDisplayedYet" && errUIPluginPathExists != nil {
    r.Log.Info("NMState ui-plugin is not set, to enable this feature, please consult NMState documentation");
}

[dougsland]

@orenc1 BTW, Thanks for the patch !!

[orenc1]

i'm not sure, because if at this point the manifests of the ui plugin are missing from the operator container, the users can't do much in order to deploy the ui plugin at this point, since the operator is expecting the manifests to be included in the container.

[dougsland]

thanks! I will let others in the group review and approve :)

[qinqon]

/lgtm
/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [qinqon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qinqon]

/retest

[qinqon]

/ok-to-test
/retest

There is something bad at centos 9 stream

[dougsland]

The error doesn't seem related to the patch:

 GPG Keys are configured as: file:///etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial
Public key for scl-utils-2.0.3-4.el9.x86_64.rpm is not installed. Failing package is: scl-utils-1:2.0.3-4.el9.x86_64
 GPG Keys are configured as: file:///etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial
The downloaded packages were saved in cache until the next successful transaction.
You can remove cached packages by executing 'dnf clean packages'.
Error: GPG check FAILED
Error: building at STEP "RUN dnf install -y golang-$(sed -En 's/^go +(.*+)$/\1/p' go.mod).*": while running runtime: exit status 1

[dougsland]

/retest-required

[cybertron]

There's a problem with the centos 9 repos. A workaround is proposed here #1168 so that will need to merge before this will pass.

[qinqon]

/retest

The centos 9 stream RPM issue has being fixed upstream, but looks like we have e2e test issue at main

[qinqon]

/retest