Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Integrate structured golang nmstate api #1203

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: Integrate structured golang nmstate api #1203

wants to merge 1 commit into from

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Sep 12, 2023 •
edited

/kind enhancement

What this PR does / why we need it:
TODO:

  • Use patch to update nns if needed
  • Convert to struct the expanded NNCP
  • Remove any reference to gjson and the like.

Special notes for your reviewer:

Release note:

@kubevirt-bot
Copy link
Collaborator

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL labels Sep 12, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qinqon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qinqon qinqon force-pushed the structured-network-state branch 2 times, most recently from 0418c91 to 66cfb73 Compare September 14, 2023 10:43
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2023
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2023
@qinqon qinqon force-pushed the structured-network-state branch 4 times, most recently from 24ad453 to 88323db Compare September 19, 2023 08:41
@qinqon qinqon force-pushed the structured-network-state branch 2 times, most recently from 65f22a4 to 631b909 Compare September 28, 2023 12:22
@qinqon
Copy link
Member Author

qinqon commented Sep 28, 2023

/retest

@qinqon qinqon force-pushed the structured-network-state branch 2 times, most recently from 91d2274 to 15bb9e1 Compare October 3, 2023 07:56
@qinqon
Copy link
Member Author

qinqon commented Oct 3, 2023

/retest

Error: creating build container: copying system image from manifest list: reading blob sha256:b1cffa2faa181e937919f7cf2e9e3ebfd3a6729cf308c5b5e09c88620306f5de: fetching blob: received unexpected HTTP status: 500 Internal Server Error

@qinqon qinqon changed the title wip WIP: Integrate structured golang nmstate api Oct 3, 2023
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2023
@qinqon
Copy link
Member Author

qinqon commented Oct 3, 2023

/retest

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2023
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2023
@qinqon qinqon force-pushed the structured-network-state branch 4 times, most recently from 49e5d1a to 2cd1b9a Compare November 7, 2023 10:44
@qinqon qinqon force-pushed the structured-network-state branch 2 times, most recently from f299582 to 628b1d4 Compare December 5, 2023 13:25
@qinqon qinqon mentioned this pull request Dec 5, 2023
Closed
10 tasks
@qinqon qinqon force-pushed the structured-network-state branch 3 times, most recently from 7ad3070 to dd902b3 Compare December 5, 2023 16:24
@qinqon qinqon force-pushed the structured-network-state branch 3 times, most recently from 76a20af to 12276cc Compare January 22, 2024 14:45
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2024
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2024
@qinqon
Copy link
Member Author

qinqon commented Jan 31, 2024

/test pull-kubernetes-nmstate-unit-test

1 similar comment
@qinqon
Copy link
Member Author

qinqon commented Jan 31, 2024

/test pull-kubernetes-nmstate-unit-test

@qinqon qinqon force-pushed the structured-network-state branch 2 times, most recently from e6bf3fd to 4d5941d Compare February 2, 2024 12:01
@qinqon
nns and nnce
5b3742d 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@kubevirt-bot
Copy link
Collaborator

@qinqon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future 5b3742d link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future
pull-kubernetes-nmstate-e2e-handler-k8s 5b3742d link true /test pull-kubernetes-nmstate-e2e-handler-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2024
@kubevirt-bot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cybertron cybertron Awaiting requested review from cybertron

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qinqon @kubevirt-bot