Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: Bump to 1.20 #1224

Merged
merged 1 commit into from
Jan 30, 2024
Merged

go: Bump to 1.20 #1224

merged 1 commit into from
Jan 30, 2024

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Jan 26, 2024

What this PR does / why we need it:

Bump go to 1.20

go1.20

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Jan 26, 2024
@qinqon
Copy link
Member Author

qinqon commented Jan 26, 2024

/cc @mkowalski

@mkowalski
Copy link
Member

/retest
/lgtm

This makes sense, I will happily start using more recent go

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
@mkowalski
Copy link
Member

/retest

@mkowalski
Copy link
Member

/test pull-kubernetes-nmstate-e2e-handler-k8s-future

@kubevirt-bot
Copy link
Collaborator

@qinqon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future 290a216 link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cybertron
Copy link
Collaborator

/retest-required
/approved

@cybertron
Copy link
Collaborator

/approve

Typing is hard. :-)

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@qinqon
Copy link
Member Author

qinqon commented Jan 29, 2024

Something is broken at nmstate, future lane is failing at doing an ovs-bridge with with an "state: ignore" (unamanaged) interface

@qinqon
Copy link
Member Author

qinqon commented Jan 29, 2024

/test pull-kubenetes-nmstate-unit-test

@kubevirt-bot
Copy link
Collaborator

@qinqon: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-kubernetes-nmstate-docs
  • /test pull-kubernetes-nmstate-e2e-handler-k8s
  • /test pull-kubernetes-nmstate-e2e-operator-k8s
  • /test pull-kubernetes-nmstate-unit-test

The following commands are available to trigger optional jobs:

  • /test pull-kubernetes-nmstate-e2e-handler-k8s-future
  • /test pull-kubernetes-nmstate-e2e-upgrade-k8s

Use /test all to run all jobs.

In response to this:

/test pull-kubenetes-nmstate-unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qinqon
Copy link
Member Author

qinqon commented Jan 29, 2024

/test pull-kubernetes-nmstate-unit-test

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@kubevirt-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@kubevirt-bot kubevirt-bot added size/L and removed lgtm Indicates that a PR is ready to be merged. size/S labels Jan 30, 2024
@qinqon qinqon merged commit 649ac37 into nmstate:main Jan 30, 2024
6 of 8 checks passed
@qinqon qinqon deleted the go1.20 branch January 30, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants