-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for global DNS configuration #1226
Conversation
Signed-off-by: Mat Kowalski <mko@redhat.com>
49ad247
to
e460a86
Compare
/test pull-kubernetes-nmstate-unit-test It may be a valid issue
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure related or not. It is known that nmstate will always use global DNS for:
---
dns-resolver:
config:
server:
- 2001:4860:4860::8888
- 8.8.8.8
- 2606:4700:4700::1111
With a rollback triggered by bad config, you may verify whether global DNS is reverted or not. Of course, you need mark it as known to be fail.
But those servers are good, so they will not trigger the revert. If I read the current code correctly, we want the test to contain hardcoded wrong DNS server, that's why I used 192.168.100.3 |
/retest |
/test pull-kubernetes-nmstate-unit-test |
/retest |
/hold This test is expected to fail until we have NM fixed. Currently it configures 192.168.100.3 (fake) and never rolls it back
|
/retest |
/retest
|
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/hold cancel That should actually work |
Is this a BUG FIX or a FEATURE ?:
/kind enhancement
What this PR does / why we need it:
Special notes for your reviewer:
Release note: