-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: Use metrics container when executing commands #1238
base: main
Are you sure you want to change the base?
Conversation
This PR adds explicit `-c nmstate-metrics` to the command invocations that use `kubectl.sh exec [...]`. This should not change the current behaviour as by default we execture them in this container, however it's been noticed that the following stderr is produced ``` stderr: Defaulted container "nmstate-metrics" out of: nmstate-metrics, kube-rbac-proxy ``` so for being explict, we are defining where to execute the command. Signed-off-by: Mat Kowalski <mko@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mkowalski: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@mkowalski looks like this is failing
|
/hold Maybe we will not even need that. Error makes sense, I composed the command wrongly
|
Well this is not extra important since the default container is in the first one the list but it's true that the warning is bothering. |
It was purely for cosmetic reasons because when I parse output as a human I like to see empty |
This PR adds explicit
-c nmstate-metrics
to the command invocations that usekubectl.sh exec [...]
. This should not change the current behaviour as by default we execture them in this container, however it's been noticed that the following stderr is producedso for being explict, we are defining where to execute the command.
Release note: