Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-36487: Update consoleplugin version #1251

Merged
merged 1 commit into from
Jul 24, 2024
Merged

OCPBUGS-36487: Update consoleplugin version #1251

merged 1 commit into from
Jul 24, 2024

Conversation

upalatucci
Copy link
Contributor

@upalatucci upalatucci commented Jul 12, 2024 •
edited

due to webhook conversion error

Is this a BUG FIX or a FEATURE ?:

Bug

What this PR does / why we need it:

Webhook conversion seems to fail on 4.17. So we have to upgrade ConsolePlugin version and use a more updated spec structure

Special notes for your reviewer:

Release note:

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 12, 2024
@kubevirt-bot
Copy link
Collaborator

Hi @upalatucci. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2024
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 12, 2024
@upalatucci upalatucci force-pushed the patch-1 branch 2 times, most recently from 5147240 to 1ca66c1 Compare July 12, 2024 13:13
@upalatucci
Update consoleplugin version
fe5070d 
due to webhook conversion error

Signed-off-by: Ugo Palatucci <upalatuc@redhat.com>
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2024
@upalatucci upalatucci changed the title Update consoleplugin version OCPBUGS-36487: Update consoleplugin version Jul 15, 2024
@qinqon
Copy link
Member

qinqon commented Jul 23, 2024

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@qiowang721
Copy link

/jira refresh

1 similar comment
@upalatucci
Copy link
Contributor Author

/jira refresh

@upalatucci
Copy link
Contributor Author

/remove-label do-not-merge/release-note-label-needed

@kubevirt-bot
Copy link
Collaborator

@upalatucci: The label(s) `/remove-label do-not-merge/release-note-label-needed

cannot be applied. These labels are supported: ``. Is this label configured underlabels -> additional_labelsorlabels -> restricted_labelsinplugin.yaml`?

In response to this:

/remove-label do-not-merge/release-note-label-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@upalatucci
Copy link
Contributor Author

/check-required-labels

@qiowang721
Copy link

/jira refresh

1 similar comment
@qiowang721
Copy link

/jira refresh

@upalatucci
Copy link
Contributor Author

/release-note-none

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 24, 2024
@kubevirt-bot kubevirt-bot merged commit 085e77d into nmstate:main Jul 24, 2024
8 checks passed
@upalatucci upalatucci mentioned this pull request Aug 6, 2024
Merged
openshift-merge-bot bot added a commit to openshift/kubernetes-nmstate that referenced this pull request Aug 6, 2024
@openshift-merge-bot
Merge pull request #504 from upalatucci/backport-4.16
67dea61 
Backport nmstate#1251 to 4.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek Awaiting requested review from phoracek

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@qinqon qinqon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@upalatucci @kubevirt-bot @qinqon @qiowang721