openshift: Ensure new webhook secret #1268
Conversation
kubevirt-bot
added
release-note
qinqon
force-pushed
the
openshift-cert-manager-follow-up
branch
from
0ac9bd4 to
9dbefbb
Compare
The non openshift secret is not compatible with openshift generated version, this change a different one so they don't collide and also remove the old one. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
qinqon
force-pushed
the
openshift-cert-manager-follow-up
branch
from
9dbefbb to
4bd135b
Compare
|
/retest |
| @@ -391,7 +395,7 @@ metadata: | |||
| name: {{template "handlerPrefix" .}}nmstate-webhook | |||
| namespace: {{ .HandlerNamespace }} | |||
| annotations: | |||
| service.beta.openshift.io/serving-cert-secret-name: {{template "handlerPrefix" .}}nmstate-webhook | |||
| service.beta.openshift.io/serving-cert-secret-name: {{template "handlerPrefix" .}}openshift-nmstate-webhook | |||
There was a problem hiding this comment.
This line also around {{- if not .IsOpenShift }}, I guess
There was a problem hiding this comment.
Not needed, this annotation is only used by openshift, so it's ok to have it there like this upstream.
|
/retest |
|
/test pull-kubernetes-nmstate-e2e-handler-k8s |
|
@qinqon: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test pull-kubernetes-nmstate-e2e-handler-k8s |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
The non openshift secret is not compatible with openshift generated version, this change a different one so they don't collide and also remove the old one. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
The non openshift secret is not compatible with openshift generated version, this change a different one so they don't collide and also remove the old one. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
The non openshift secret is not compatible with openshift generated version, this change a different one so they don't collide and also remove the old one.