Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to golang 1.17 #964

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Update to golang 1.17 #964

merged 1 commit into from
Jan 18, 2022

Conversation

creydr
Copy link
Collaborator

@creydr creydr commented Jan 18, 2022

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What this PR does / why we need it:
Update to golang 1.17

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/enhancement dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 18, 2022
@creydr
Copy link
Collaborator Author

creydr commented Jan 18, 2022

/test pull-kubernetes-nmstate-e2e-handler-k8s-future

@qinqon
Copy link
Member

qinqon commented Jan 18, 2022

@creydr can you rebase on top of #965 ?

@creydr
Copy link
Collaborator Author

creydr commented Jan 18, 2022 •
edited
Loading

@creydr can you rebase on top of #965 ?

@qinqon: done

@creydr
Update to golang 1.17
957d255 
Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@creydr
Copy link
Collaborator Author

creydr commented Jan 18, 2022

@qinqon after #965 got merged, I rebased this PR on main branch again

@qinqon
Copy link
Member

qinqon commented Jan 18, 2022

/ok-to-test
/lgtm
/approve

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Jan 18, 2022
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2022
@kubevirt-bot
Copy link
Collaborator

@creydr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future 957d255 link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot merged commit 94536d7 into nmstate:main Jan 18, 2022
@creydr creydr mentioned this pull request Jan 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinqon qinqon Awaiting requested review from qinqon

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@qinqon qinqon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/enhancement lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@creydr @qinqon @kubevirt-bot