-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding of cards for users #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich würde sowohl die edit-card-logik als auch die neuere version von material design gerne in 'nem anderen PR machen…
Ich glaube, auch die tests gehören in 'nen anderen PR - aus meiner sicht sollten die Commits auf master (squashed) recht atomar bleiben, sprich du hast 'nen "add functionality" und 'nen "add test for…"-commit
<td class="mdl-data-table__cell--non-numeric">{{ printf "%x" .ID }}</td> | ||
<td class="mdl-data-table__cell--non-numeric">{{ .Description }}</td> | ||
<td class="mdl-data-table__cell--non-numeric"><a href="edit_card.html?uid={{ printf "%x" .ID }}">edit</a></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
können wir "edit card" in 'nen separaten PR auslagern? Das ist 'ne ganz andere Art von Funktionalität :))
Okay… I broke git somehow. I'll fix this and separate the features into different PRs later :) |
The Kasse now has an attribute card, which is a binary slice channel HandleCard writes in this channel, if some other go routine is listening remove flashing messages during registration for now
remove dependency on polyfill
please review this, when you find the time 😄