Allow adding of cards for users #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koebi
requested changes
Sep 15, 2019
There was a problem hiding this comment.
Ich würde sowohl die edit-card-logik als auch die neuere version von material design gerne in 'nem anderen PR machen…
Ich glaube, auch die tests gehören in 'nen anderen PR - aus meiner sicht sollten die Commits auf master (squashed) recht atomar bleiben, sprich du hast 'nen "add functionality" und 'nen "add test for…"-commit
| <td class="mdl-data-table__cell--non-numeric">{{ printf "%x" .ID }}</td> | ||
| <td class="mdl-data-table__cell--non-numeric">{{ .Description }}</td> | ||
| <td class="mdl-data-table__cell--non-numeric"><a href="edit_card.html?uid={{ printf "%x" .ID }}">edit</a></td> |
There was a problem hiding this comment.
können wir "edit card" in 'nen separaten PR auslagern? Das ist 'ne ganz andere Art von Funktionalität :))
This was referenced Sep 26, 2019
|
Okay… I broke git somehow. I'll fix this and separate the features into different PRs later :) |
The Kasse now has an attribute card, which is a binary slice channel HandleCard writes in this channel, if some other go routine is listening remove flashing messages during registration for now
remove dependency on polyfill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please review this, when you find the time 😄