Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gbs] Let tizen gbs build use cache properly #744

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anyj0527
Copy link
Member

@anyj0527 anyj0527 commented Sep 5, 2023

  • Currently only the first arch option use the gbs build cache.
  • Remove GBS-ROOT folder when all the tizen gbs build is finished.
  • Expecting quite a time boost on gbs build tasks by removing rpm downloading.

Self evaluation:

  1. Build test: [ ]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ] Skipped

- Currently only the first arch option use the gbs build cache.
- Remove GBS-ROOT folder when all the tizen gbs build is finished.

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
@taos-ci
Copy link
Collaborator

taos-ci commented Sep 5, 2023

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #744. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anyj0527, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove GBS-ROOT conditionally? (e.g., the first check of a day or 10% probability or explicit input from users via webhook? ...)

Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove GBS-ROOT conditionally? (e.g., the first check of a day or 10% probability or explicit input from users via webhook? ...)

@anyj0527
Copy link
Member Author

anyj0527 commented Sep 6, 2023

@myungjoo
Well currently the GBS-ROOT is created per PR with global gbs repo cache. I'm not sure that sharing GBS-ROOT among multiple PRs would be more effective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants