-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python examples #58
Python examples #58
Conversation
with a few plots of the default cases
@zmoon Thank you so much for doing all of this! Understood that you should very soon turn your attention to UFS/NEXUS, but if we wrap this up it would be helpful! Thanks again. |
Looks like running the example nb currently takes ~ 50 s in CI. Not bad, but will later (probably not in this PR) add parallel sensitivity run option which will help with this. |
since on Binder it gets `jovyan` instead of `canopy-app`
@zmoon Thank you for continuing to work and wrap up these great Python examples and binder for the tests...I think it will be a great way for us to test canopy-app more effectively! |
@drnimbusrain how do we want to address the var differences? The bio emi ones are the same, the differences are:
Note that canopy height isn't in the nc output but is in the txt output. The txt names are formed in the Python by taking those in the text output header and lowercasing and replacing |
@zmoon This is a great point on the inconsistent variables. I will add "canheight" to the NC output and change the txt output variable names to be consistent. |
Ok, do you want to do it in this PR? Or let me attempt and then you can review? |
@zmoon great to do it on this PR, and would appreciate if you could attempt then... |
names + including more units
@drnimbusrain I'll remove your notes from the nb after you review, want to leave them for now so you have them. |
I know I already changed it to |
Hi Zach, I am Ok with using WS for the canopy wind speed variable name.
Please proceed.
…On Tue, Apr 25, 2023, 11:35 AM Zachary Moon ***@***.***> wrote:
I know I already changed it to canwind, but in retrospect maybe ws is
better since WS above the canopy is included too, yes? Also fine with
canwind though.
—
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLFYNSYDHBYJDS4Q6G4SB3XC7VLTANCNFSM6AAAAAAW5O6S3A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@zmoon I think this looks great! You can remove my notes and merge. |
kept the ones explaining some of the options, but moved to within the code
todo: