Bio opts #73
Merged
Bio opts #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmoon
reviewed
May 31, 2023
Co-authored-by: Zachary Moon <zachary.moon@noaa.gov>
zmoon
reviewed
Jun 1, 2023
zmoon
reviewed
Jun 1, 2023
Co-authored-by: Zachary Moon <zachary.moon@noaa.gov>
|
@zmoon Where we at with this? |
|
I want to add brief example to the examples nb. |
for the point case
zmoon
reviewed
Jun 8, 2023
README.md
Outdated
| @@ -197,6 +197,13 @@ https://nacc-in-the-cloud.s3.amazonaws.com/inputs/geo-files/gfs.canopy.t12z.2022 | |||
| | `lu_opt` | integer for input model land use type (`0`: VIIRS 17 Cat (default) or `1`: MODIS-IGBP 20 Cat (valid LU types 1-10 and 12); input mapped to Massman et al.) | | |||
| | `z0_opt` | integer (`0`: use model input or `1`: vegtype dependent z0 for first estimate) | | |||
| | `bio_cce` | user-set real value of MEGAN biogenic emissions "canopy environment coefficient" used to tune emissions to model inputs/calculations (default: `0.21`, based on Silva et al. 2020) | | |||
| | `bio_vert` | user set biogenic vertical summing option (`0`: no sum, full leaf-level biogenic emissions, units=kg/m3/s; `1`: MEGANv3-like summing of LAD weighted activity coefficients using the canopy-app plant distributions, caution-- units=kg m-2 s-1 and puts the total emissions in the topmost canopy-app model layer only; `2`: Same as in option 1, but instead uses Gaussian/normally weighted activity coefficients acoss all sub-canopy layers -- also units of kg m-2 s-1 in topmost model layer; `3`: Same as in option 1, but instead uses evenly weighted activity coefficients acoss all sub-canopy layers -- also units of kg m-2 s-1 in topmost model layer | | |||
There was a problem hiding this comment.
Should it be bio_vert_opt instead? Seems like the integer option params usually end in _opt.
There was a problem hiding this comment.
Yes, do you want to change it, or me?
|
Sure Zach, I'll make that change.
…On Thu, Jun 8, 2023, 9:50 PM Zachary Moon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#73 (comment)>
:
> @@ -197,6 +197,13 @@ https://nacc-in-the-cloud.s3.amazonaws.com/inputs/geo-files/gfs.canopy.t12z.2022
| `lu_opt` | integer for input model land use type (`0`: VIIRS 17 Cat (default) or `1`: MODIS-IGBP 20 Cat (valid LU types 1-10 and 12); input mapped to Massman et al.) |
| `z0_opt` | integer (`0`: use model input or `1`: vegtype dependent z0 for first estimate) |
| `bio_cce` | user-set real value of MEGAN biogenic emissions "canopy environment coefficient" used to tune emissions to model inputs/calculations (default: `0.21`, based on Silva et al. 2020) |
+| `bio_vert` | user set biogenic vertical summing option (`0`: no sum, full leaf-level biogenic emissions, units=kg/m3/s; `1`: MEGANv3-like summing of LAD weighted activity coefficients using the canopy-app plant distributions, caution-- units=kg m-2 s-1 and puts the total emissions in the topmost canopy-app model layer only; `2`: Same as in option 1, but instead uses Gaussian/normally weighted activity coefficients acoss all sub-canopy layers -- also units of kg m-2 s-1 in topmost model layer; `3`: Same as in option 1, but instead uses evenly weighted activity coefficients acoss all sub-canopy layers -- also units of kg m-2 s-1 in topmost model layer |
You, if you don't mind!
—
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLFYNSXB3M2VNIDNZIJDCLXKJ6OJANCNFSM6AAAAAAYV64JWI>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
@zmoon OK, I changed bio_vert to biovert_opt to conform. |
zmoon
reviewed
Jun 9, 2023
Co-authored-by: Zachary Moon <zachary.moon@noaa.gov>
|
@zmoon Are we ready to merge? |
zmoon
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to merge updated biogenic options and diagnostics for testing and comparison against MEGAN. These inlude: