Import 5 canopy arrays and 3 photdiag arrays from AQM #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iri01 Please comment on this, and I assume we are still waiting on updates to some other files to account for new canopy variables in the ccpp/data GFS .F90 and meta files? |
|
I have converted this to draft until you get the other files necessary updated here. |
drnimbusrain
requested changes
Feb 28, 2024
ccpp/data/GFS_typedefs.meta
Outdated
| dimensions = (horizontal_loop_extent) | ||
| type = real | ||
| kind = kind_phys | ||
| ### IVAI | ||
| [canopylaixy] | ||
| standard_name = canopy_leaf_area_index | ||
| long_name = canopy leaf area index |
There was a problem hiding this comment.
@iri01 I am not really using these test canopylaixy and other canopy variables below, and the compilation may complain about duplicate standard names, so I would comment all these "...xy" variables I put below.
drnimbusrain
approved these changes
Feb 28, 2024
drnimbusrain
pushed a commit
that referenced
this pull request
May 2, 2024
* In GFS_diagnostics make LAI, WILT and FLDCP be outputted with all LSMs. Also, output of LAI should not depend on RDLAI. * In GFS_typedefs.* add surface heat flux from the fire for use in RUC LSM. * Fix hail size output diagnostic array size (#1) * Added one more variable - frac_grid_burned_out - to GFS_typedefs.F90. Also, the surface heat flux from fires and frac_grid_burned_out are added to the model output in GFS_diagnostics.F90. --------- Co-authored-by: tanyasmirnova <tanya.smirnova@noaa.gov> Co-authored-by: Anders Jensen <anders.jensen@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
Import 5 canopy arrays and 3 photdiag output arrays from AQM
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Consistent use of canopy data in photolysis and diffusion, formerly diffusion using LSM Noah look-up table. Enable 2D photolysis diagnostics.
Testing
How were these changes tested?
Tested on rdhpcs hera.
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
The use the AQM canopy data in diffusion changes the results when 'do_canopy' correction is selected.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
feature/aqm_canopy
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs