feat: add basic command history #33
Conversation
|
@nerg4l thanks for your contribution! This works great for me. Just left one question but looks good to go otherwise. |
| @@ -90,6 +90,7 @@ func (b Bubble) Update(msg tea.Msg) (tea.Model, tea.Cmd) { | |||
| cmd = b.writeOutputToFile() | |||
| cmds = append(cmds, cmd) | |||
| } else if b.state == state.Query { | |||
| b.queryinput.RotateHistory() | |||
There was a problem hiding this comment.
Is this needed if we're handling the Enter message in the queryinput bubble?
There was a problem hiding this comment.
Unfortunately, the state changes from Query to Running in the next line, and because of that, the enter key message never reaches the queryinput.Bubble component. I did not wanted to change much. Do you have a suggestion for handling this?
There was a problem hiding this comment.
Ah, I see. This is fine for now. I think a future improvement for jqp will just be refactoring some of this state management to be able to pass messages to sub models when they are not in focus.
|
Going to go ahead and merge this @nerg4l. Thanks again for your contribution! I think we'll be able to build on this by maybe showing a view of all history or something like that. And to your original comment in the PR description, I've been interested in using bubbline but just haven't had a chance to explore and implement it yet. From what I understand, there is a completion API and some other really nice features in that. Would take a bit of work to get it wired into jqp, but think it could really make it special. If you're interested in doing that or want to take a different approach, PRs are most certainly welcome :D. Cheers! |
Related to #11
A really basic command history. Features:
More complex behaviour (e.g. history suggestion with tab trigger) could be added by replacing
textinput.Modelofqueryinput.Bubblewith a fully custom model.