fix: don't block while inputdata bubble initializes #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahgorstein
force-pushed
the
fix/dont-block-view-while-syntax-highlighting-blocks
branch
2 times, most recently
from
b5ace7b
to
0937c2f
Compare
noahgorstein
force-pushed
the
fix/dont-block-view-while-syntax-highlighting-blocks
branch
from
0937c2f
to
8b12579
Compare
noahgorstein
changed the title
noahgorstein
deleted the
fix/dont-block-view-while-syntax-highlighting-blocks
branch
d-issy
referenced
this pull request
in d-issy/dotfiles
Jun 10, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [noahgorstein/jqp](https://github.com/noahgorstein/jqp) | minor | `v0.6.0` -> `v0.7.0` | --- ### Release Notes <details> <summary>noahgorstein/jqp (noahgorstein/jqp)</summary> ### [`v0.7.0`](https://github.com/noahgorstein/jqp/releases/tag/v0.7.0) [Compare Source](https://github.com/noahgorstein/jqp/compare/v0.6.0...v0.7.0) #### Overview Mostly small bug fixes and some performance improvements. One new feature added is the ability to specify an optional query argument to `jqp` cli that it will execute on startup. curl "https://api.github.com/repos/jqlang/jq/issues" | jqp '.[] | {"title": .title, "url": .url}' https://github.com/noahgorstein/jqp/assets/23270779/735cf84a-dc6f-41e8-9659-5022a4937046 [@​EmilyGraceSeville7cf](https://github.com/EmilyGraceSeville7cf) also added a JSON schema for jqp's config which should help users create and edit their config files. #### What's Changed - typos suggestion by [@​ccoVeille](https://github.com/ccoVeille) in [https://github.com/noahgorstein/jqp/pull/59](https://github.com/noahgorstein/jqp/pull/59) - code review by [@​ccoVeille](https://github.com/ccoVeille) in [https://github.com/noahgorstein/jqp/pull/61](https://github.com/noahgorstein/jqp/pull/61) - Add Continuous Integration to GitHub actions by [@​ccoVeille](https://github.com/ccoVeille) in [https://github.com/noahgorstein/jqp/pull/63](https://github.com/noahgorstein/jqp/pull/63) - Add GitHub actions for checking typos by [@​ccoVeille](https://github.com/ccoVeille) in [https://github.com/noahgorstein/jqp/pull/62](https://github.com/noahgorstein/jqp/pull/62) - Add dependabot to GitHub Action by [@​ccoVeille](https://github.com/ccoVeille) in [https://github.com/noahgorstein/jqp/pull/64](https://github.com/noahgorstein/jqp/pull/64) - chore: address golangci-lint issues by [@​noahgorstein](https://github.com/noahgorstein) in [https://github.com/noahgorstein/jqp/pull/74](https://github.com/noahgorstein/jqp/pull/74) - chore(deps): bump github.com/itchyny/gojq from 0.12.13 to 0.12.15 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/72](https://github.com/noahgorstein/jqp/pull/72) - chore(deps): bump github.com/alecthomas/chroma/v2 from 2.12.0 to 2.13.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/73](https://github.com/noahgorstein/jqp/pull/73) - chore(deps): bump github.com/charmbracelet/bubbles from 0.16.1 to 0.18.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/71](https://github.com/noahgorstein/jqp/pull/71) - chore(deps): bump github.com/charmbracelet/lipgloss from 0.8.0 to 0.10.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/70](https://github.com/noahgorstein/jqp/pull/70) - chore(deps): bump github.com/spf13/cobra from 1.5.0 to 1.8.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/69](https://github.com/noahgorstein/jqp/pull/69) - chore(deps): bump github.com/spf13/viper from 1.13.0 to 1.18.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/68](https://github.com/noahgorstein/jqp/pull/68) - chore(deps): bump github.com/charmbracelet/bubbletea from 0.24.1 to 0.26.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/67](https://github.com/noahgorstein/jqp/pull/67) - chore(deps): bump actions/setup-go from 4 to 5 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/66](https://github.com/noahgorstein/jqp/pull/66) - chore: upgrade to go v1.22 by [@​noahgorstein](https://github.com/noahgorstein) in [https://github.com/noahgorstein/jqp/pull/75](https://github.com/noahgorstein/jqp/pull/75) - refactor: reduce complexity of various methods/functions by [@​noahgorstein](https://github.com/noahgorstein) in [https://github.com/noahgorstein/jqp/pull/76](https://github.com/noahgorstein/jqp/pull/76) - feat: add optional cli argument to specify initial query by [@​noahgorstein](https://github.com/noahgorstein) in [https://github.com/noahgorstein/jqp/pull/77](https://github.com/noahgorstein/jqp/pull/77) - bug: dont set viewport content on resize by [@​noahgorstein](https://github.com/noahgorstein) in [https://github.com/noahgorstein/jqp/pull/79](https://github.com/noahgorstein/jqp/pull/79) - chore(deps): bump github.com/itchyny/gojq from 0.12.15 to 0.12.16 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/85](https://github.com/noahgorstein/jqp/pull/85) - chore(deps): bump github.com/alecthomas/chroma/v2 from 2.13.0 to 2.14.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/80](https://github.com/noahgorstein/jqp/pull/80) - chore(deps): bump github.com/charmbracelet/lipgloss from 0.10.0 to 0.11.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/82](https://github.com/noahgorstein/jqp/pull/82) - chore(deps): bump github.com/spf13/viper from 1.18.2 to 1.19.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/84](https://github.com/noahgorstein/jqp/pull/84) - chore(deps): bump github.com/charmbracelet/bubbletea from 0.26.2 to 0.26.4 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/83](https://github.com/noahgorstein/jqp/pull/83) - fix: revert to lipgloss v0.10.0 temporarily by [@​noahgorstein](https://github.com/noahgorstein) in [https://github.com/noahgorstein/jqp/pull/87](https://github.com/noahgorstein/jqp/pull/87) - fix: don't block while inputdata bubble initializes by [@​noahgorstein](https://github.com/noahgorstein) in [https://github.com/noahgorstein/jqp/pull/86](https://github.com/noahgorstein/jqp/pull/86) - fix: nil pointer dereference as a result of accessing state before queryinput initialized by [@​noahgorstein](https://github.com/noahgorstein) in [https://github.com/noahgorstein/jqp/pull/90](https://github.com/noahgorstein/jqp/pull/90) - fix: dynamically increase buffer size to handle processing large JSON lines by [@​noahgorstein](https://github.com/noahgorstein) in [https://github.com/noahgorstein/jqp/pull/93](https://github.com/noahgorstein/jqp/pull/93) - chore(deps): bump github.com/charmbracelet/lipgloss from 0.10.0 to 0.11.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/89](https://github.com/noahgorstein/jqp/pull/89) - chore(deps): bump crate-ci/typos from 1.21.0 to 1.22.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/noahgorstein/jqp/pull/92](https://github.com/noahgorstein/jqp/pull/92) - feat: implement json schema for config by [@​EmilyGraceSeville7cf](https://github.com/EmilyGraceSeville7cf) in [https://github.com/noahgorstein/jqp/pull/78](https://github.com/noahgorstein/jqp/pull/78) - chore: prep v0.7.0 release by [@​noahgorstein](https://github.com/noahgorstein) in [https://github.com/noahgorstein/jqp/pull/94](https://github.com/noahgorstein/jqp/pull/94) #### New Contributors - [@​ccoVeille](https://github.com/ccoVeille) made their first contribution in [https://github.com/noahgorstein/jqp/pull/59](https://github.com/noahgorstein/jqp/pull/59) - [@​dependabot](https://github.com/dependabot) made their first contribution in [https://github.com/noahgorstein/jqp/pull/72](https://github.com/noahgorstein/jqp/pull/72) - [@​EmilyGraceSeville7cf](https://github.com/EmilyGraceSeville7cf) made their first contribution in [https://github.com/noahgorstein/jqp/pull/78](https://github.com/noahgorstein/jqp/pull/78) **Full Changelog**: noahgorstein/jqp@v0.6.0...v0.7.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/d-issy/dotfiles). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly applies for larger inputs (>1-2MB). It turns out prettifying the input data (syntax highlighting with Chroma) can be a bottleneck in jqp. The changes here allow for the prettification of input data to be performed asynchronously, reducing the likelihood of blocking the main thread, especially with large inputs.
See the experience using jqp on a 9MB file before and after this change. You can see something a little odd happens with the view here as a result of components not being updated (and thus resized) as a result of the syntax highlighting blocking the main event loop in Bubbletea.
before:
after:
Note
a better implementation is probably incrementally highlighting whatever data is visible in the viewports but a little too much to bite of now.