feat: add createdAt and createdBy to project #422
Conversation
Signed-off-by: shubhindia <shubhindia123@gmail.com>
shubhindia
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
shubhindia
changed the title
shubhindia
changed the title
|
hey @shubhindia ;) This is certainly doable, we need to consult this idea in our team responsible for object's API though :) I'll let you know once we have some thoughts/details on this one, thanks for bringing this up! |
Yup. Ideally it should be available for all the objects, but since I was working on projects, I added for them. Let me know if you guys decide to add it for other objects too. Happy to make that change here 😄 |
|
We talked through this today and we'd want to support those fields on most of our objects. I'll work on the changes for our internal system to support returning these fields, once that's done we'll merge this one. Afterwards I'll work on extending support for these fields for other objects as well :) |
Cool. Sounds good 😁 |
There was a problem hiding this comment.
Thanks once again for the idea and contribution :)
Once our platform ships with support for these fields I'll let you know!
You can also follow our release notes.
|
The changes are available in https://github.com/nobl9/nobl9-go/releases/tag/v0.82.0. |
…ct.Spec fields (#144) ## Motivation With the introduction of new server-side computed fields for v1alpha Project.Spec: `createdAt` and `createdBy` the tests started failing as the helper function `_assert_objects_existence` was comparing almost the whole object. This is too much for a simple assertion that checks if the object was actually applied, so I added additional filter to re-map the objects, extracting the basic minimum for comparison. ## Related Changes - nobl9/nobl9-go#422 ## Testing Run `make test/e2e`, remember about supplying the right env vars OR run https://github.com/nobl9/sloctl/actions/workflows/e2e-tests-dispatch.yml with this branch as target.
Motivation
Right now there is no info for the project about when it was created and who created it. We are developing some internal APIs to manage nobl9, and would love to get this info added.
Summary
I have added relevant fields to the
Projectstruct, the core controller needs to populate these fields, but since it isn't open-source, I can't do that myself.@nieomylnieja Let me know your thoughts 😄
Release Notes
Added
createdAtandcreatedByfields to v1alpha Project.These fields are not yet populated by the API, follow our release notes to get informed when the API support ships.