feat: PC-14787 Enable specifying project in the command for importing #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSski
changed the title
n9-machine-user
added
go
BSski
force-pushed
the
PC-14787-enable-specifying-project-in-tf-import-command
branch
from
5b8ac3c to
3f56a22
Compare
BSski
requested review from
skrolikiewicz,
nieomylnieja and
daniel-zelazny
as code owners
BSski
force-pushed
the
PC-14787-enable-specifying-project-in-tf-import-command
branch
from
3b8ec5a to
6193c13
Compare
BSski
force-pushed
the
PC-14787-enable-specifying-project-in-tf-import-command
branch
from
4d4356e to
9ac41cb
Compare
labtom
previously approved these changes
Dec 17, 2024
Co-authored-by: Tomek Labuk <89924840+labtom@users.noreply.github.com>
Co-authored-by: Tomek Labuk <89924840+labtom@users.noreply.github.com>
…' of ssh://github.com/nobl9/terraform-provider-nobl9 into PC-14787-enable-specifying-project-in-tf-import-command
nieomylnieja
requested changes
Dec 19, 2024
| @@ -213,6 +213,17 @@ func resourceAgentDelete(ctx context.Context, d *schema.ResourceData, meta inter | |||
| return nil | |||
| } | |||
|
|
|||
| func resourceAgentImport(_ context.Context, d *schema.ResourceData, _ interface{}) ([]*schema.ResourceData, error) { | |||
| project, resourceID := parseImportID(d.Id()) | |||
| if project != "" { | |||
There was a problem hiding this comment.
what If project is empty? will it eventually use the default project? just asking
templates/index.md.tmpl
Outdated
| @@ -27,6 +27,8 @@ The Nobl9 Terraform Provider does not support the configuration of the following | |||
| - [SLO Annotations](https://docs.nobl9.com/features/slo-annotations/) | |||
| - [Alert Silence](https://docs.nobl9.com/alerting/alert-silence/) | |||
|
|
|||
| The Nobl9 Terraform Provider supports `terraform import` command. For project-bound resources, use `project_name/service_name` format. | |||
There was a problem hiding this comment.
We tend to use project-scoped, I think I've never seen project-bound phrasing before.
In addition, it seems we're not supporting all objects in this iteration, for instance Alert Policy, we should inform users about that (you can opt to list them here or just mention that selected ones are supported).
Suggested change
| The Nobl9 Terraform Provider supports `terraform import` command. For project-bound resources, use `project_name/service_name` format. | |
| The Nobl9 Terraform Provider supports `terraform import` command for selected objects. For project-scoped resources, use `project_name/object_name` format, for non-project-scoped resources simply provide the object's name. |
| d.SetId(resourceID) | ||
| return []*schema.ResourceData{d}, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
placeholder comment: why we're not adding acceptance tests for import?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
It's now possible to pass resource's project in the
terraform importcommand, e.g.terraform import nobl9_agent.agent project_name/object_name.