-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefix too long #41
prefix too long #41
Conversation
WalkthroughThe recent update in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
jpugdoc/diffextract.go (1)
Line range hint
18-18
: Several undefined variables and functions.Please define or import the following correctly:
versionTag
,Verbose
,saveCatalog
,STARTADDCOMMENTWITHC
,STARTADDCOMMENT
,ENDADDCOMMENT
,REPHIGHHUN
,STARTINDEXTERM
,ENDINDEXTERM
,SPLITCOMMENT
,RETAGBLOCK
,CLOSEPARA
,REPARA2
,NIHONGO
,stripNL
.Also applies to: 26-26, 38-38, 104-104, 116-116, 129-129, 140-140, 160-160, 163-163, 168-168, 179-179, 181-181, 201-201, 268-268, 273-273, 288-288, 291-291, 343-343, 389-389
Tools
golangci-lint
80-80: undefined: Catalog
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
go.mod
is excluded by!**/*.mod
go.sum
is excluded by!**/*.sum
Files selected for processing (1)
- jpugdoc/diffextract.go (1 hunks)
Additional context used
golangci-lint
jpugdoc/diffextract.go
80-80: undefined: Catalog
371-371: undefined: Catalog
405-405: undefined: Catalog
18-18: undefined: versionTag
26-26: undefined: Verbose
38-38: undefined: saveCatalog
104-104: undefined: STARTADDCOMMENTWITHC
116-116: undefined: STARTADDCOMMENT
129-129: undefined: ENDADDCOMMENT
140-140: undefined: REPHIGHHUN
160-160: undefined: STARTINDEXTERM
163-163: undefined: ENDINDEXTERM
168-168: undefined: ENDINDEXTERM
179-179: undefined: STARTINDEXTERM
181-181: undefined: ENDINDEXTERM
201-201: undefined: SPLITCOMMENT
268-268: undefined: RETAGBLOCK
273-273: undefined: RETAGBLOCK
288-288: undefined: CLOSEPARA
291-291: undefined: REPARA2
343-343: undefined: NIHONGO
389-389: undefined: stripNL
Additional comments not posted (1)
jpugdoc/diffextract.go (1)
83-83
: Reduced the size of theprefixes
slice from 10 to 5.This change should help in optimizing memory usage as fewer elements are now allocated to the slice.
@@ -80,7 +80,7 @@ func getDiff(vTag string, fileName string) ([]byte, error) { | |||
func Extraction(diffSrc []byte) []Catalog { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undefined type Catalog
.
Please ensure that the Catalog
type is defined within the package or imported correctly.
Also applies to: 371-371, 405-405
Tools
golangci-lint
80-80: undefined: Catalog
Summary by CodeRabbit