Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete bills #8

Merged
merged 14 commits into from
Feb 11, 2018
Merged

Delete bills #8

merged 14 commits into from
Feb 11, 2018

Commits on Jan 7, 2018

  1. Introduce UnknownExpenseExcpetion

    If an expense cannot be found within a nobt the UnknownExpenseException
    can be thrown
    KreMat committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    66040bb View commit details
    Browse the repository at this point in the history
  2. Make expenses deletable

    To remove an expense from a nobt a new Enpoint is provided
    KreMat committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    f1e4ea1 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2018

  1. Add VirtualBeanPropertyWriter for Expense-links

    The VirtualBeanPropertyWriter allows us to add dynamic properties every
    time Jackson serializes an instance of our Expense. Through the built-in
    attribute-passing mechanism of Jackson, we pass the PropertyWriter an
    instance of our LinkFactory so that the logic for actually creating the
    link lives outside of the PropertyWriter and can be easily tested.
    
    We can now also use the "delete"-link in the ApiDocumentationTest to
    delete the expense.
    thomaseizinger committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    c4c5627 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2018

  1. Add support for a scheme-overriding header

    The new config value allows to define an HTTP-header that will is used
    to override the scheme of generated links, if it contains a value. This
    is needed for our production environment at AWS because our application
    sits behind a load-balancer that accepts all requests forwards them to
    our application. The load-balancer accepts HTTPS requests but forwards
    them as HTTP. Thus, generated links would be invalid if we use the
    scheme of the current request to generate the link.
    thomaseizinger committed Jan 14, 2018
    Configuration menu
    Copy the full SHA
    68a0a18 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2018

  1. Configuration menu
    Copy the full SHA
    cc5860b View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2018

  1. Configuration menu
    Copy the full SHA
    1189594 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee2f22b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5381c7f View commit details
    Browse the repository at this point in the history
  4. Fix typo

    thomaseizinger committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    ad90115 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ba9bea4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4758bb1 View commit details
    Browse the repository at this point in the history
  7. Wrap expenses in DeletedExpense upon deletion

    This prevents DeletedExpenses to render a link for deleting them.
    thomaseizinger committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    c7db496 View commit details
    Browse the repository at this point in the history
  8. Store instant of deletion instead of deleted-flag

    This way, we also know when an expense was deleted.
    thomaseizinger committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    fb56bb7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3be7fff View commit details
    Browse the repository at this point in the history