matchHeader doesn't work in Node 8.x

[panva]

matchHeader no longer functions as expected, neither when providing value as a string or a function. The culprit seems to be options.getHeader returning undefined for every header name because request._headers (v9.0.13) is not set anymore.

[kevinoid]

I'm seeing this issue as well. It looks like this is a result of nodejs/node#10941 (nodejs/node@b377034359a specifically) which made the ._headers property of OutgoingMessage return a copy of the headers object. This copy is assigned to in setHeaders, which has no lasting effect.

Is there a reason why request.setHeader (OutgoingMessage.prototype.setHeader) isn't being called here?

[jhuliano]

Replacing the matchHeader function with nock(host, { reqheaders: {"header":"content"} }), seems to do the trick for now.
I'm using Nock 9.0.13 and Node 8 (on Official Docker Image)

[jdx]

that requires you to specify all the headers though, right?

[jhuliano]

@dickeyxxx doesn't look like it does, I don't mock all my headers and the tests are working just fine with the mentioned change.
Also the header assertions are working as expected (tests will fail if the supplied header content doesn't match the expectation).

[jdx]

good to know! thank you!

[acofer]

#930

[shahata]

any plans of fixing this soon?

[0xcaff]

It looks like this is fixed in the latest commit to master: 35c76e3

[ianwsperber]

Will be released end of weekend

[ianwsperber]

v9.0.14 out with @martinkuba's fix. Huge thanks to him for doing the work. Closing this issue. Will re-open if we get reports that issue persists.

[panva]

resolved, @ianwsperber @martinkuba thanks!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!