Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring interceptor #101

Merged
merged 5 commits into from
Jun 18, 2023
Merged

Refactoring interceptor #101

merged 5 commits into from
Jun 18, 2023

Conversation

noconnor
Copy link
Owner

@noconnor noconnor commented Jun 18, 2023

Refactoring and bug fix

Proposed Changes

  • Refactoring JUnitPerfInterceptor logic
  • Bug fix for when maven-surefire-plugin is configured to run tests within a class in parallel (fix for statement build concurrency issue)
  • Update to require @JUnitPerfTestActiveConfig annotated fields be static

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Merging #101 (a9935c7) into master (65821c6) will decrease coverage by 0.65%.
The diff coverage is 76.00%.

@@             Coverage Diff              @@
##             master     #101      +/-   ##
============================================
- Coverage     91.60%   90.96%   -0.65%     
  Complexity      332      332              
============================================
  Files            24       24              
  Lines           846      874      +28     
  Branches         76       76              
============================================
+ Hits            775      795      +20     
- Misses           60       68       +8     
  Partials         11       11              
Impacted Files Coverage Δ
...tperf/reporting/providers/HtmlReportGenerator.java 95.58% <ø> (ø)
...github/noconnor/junitperf/suite/SuiteRegistry.java 92.72% <ø> (-1.82%) ⬇️
...ithub/noconnor/junitperf/JUnitPerfInterceptor.java 83.96% <76.00%> (-3.22%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@noconnor noconnor merged commit 0a444b0 into master Jun 18, 2023
@noconnor noconnor deleted the refactoring-interceptor branch June 18, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant