Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrong RepositoryUrl property #103

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Aug 21, 2023

There were two RepositoryUrl properties, one with the correct value (https://github.com/nodatime/nodatime.serialization) and one with a wrong value (https://github.com/nodatime/nodatime).

Unfortunately, the one with the wrong value was picked when creating the NuGet package, making it difficult to find the release notes from the NuGet page that was pointing to the wrong Source repository.

There were two `RepositoryUrl` properties, one with the correct value (`https://github.com/nodatime/nodatime.serialization`) and one with a wrong value (`https://github.com/nodatime/nodatime`).

Unfortunately, the one with the wrong value was picked when creating the NuGet package, making it difficult to find the release notes from the [NuGet page](https://www.nuget.org/packages/NodaTime.Serialization.SystemTextJson) that was pointing to the wrong _Source repository_.
@jskeet
Copy link
Member

jskeet commented Aug 21, 2023

Humbug - thanks for spotting this. I'll merge now, but I probably won't get round to releasing new versions before the weekend. The SystemTextJson package will be simple as I only just released that, so it can definitely be a patch - I'll need to check the other ones more carefully for changes.

@jskeet jskeet merged commit 5e5e771 into nodatime:main Aug 21, 2023
1 check passed
@0xced 0xced deleted the Fix-RepositoryUrl branch August 21, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants