Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a JsonConverterFactory equivalent of the existing default converter attribute #99

Merged
merged 3 commits into from
Aug 13, 2023
Merged

Implement a JsonConverterFactory equivalent of the existing default converter attribute #99

merged 3 commits into from
Aug 13, 2023

Commits on Aug 13, 2023

  1. Rename files and test for NodaTimeDefaultJsonConverterAttribute

    @jskeet
    jskeet committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    fcf146b View commit details
    Browse the repository at this point in the history

  2. Add a JsonConverterFactory 

    This refactors NodaTimeDefaultJsonConverterAttribute to use the converter dictionary which is now in NodaTimeDefaultJsonConverterFactory.

Fixes nodatime#97.
    @jskeet
    jskeet committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    8f40fe8 View commit details
    Browse the repository at this point in the history

  3. Correct the XML documentation for SystemTextJson implementation of No… 

    …daConverterBase.CanConvert

It looks like System.Text.Json doesn't need or expect a converter to advertise that it can handle nullable value types. (The default implementations don't do so.)

It's entirely possible that we should actually just not override the method at all here, and only do so in NodaDateTimeZoneConverter, but I don't want to change the implementation right now.
    @jskeet
    jskeet committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    780449d View commit details
    Browse the repository at this point in the history