3.x #767
Merged
3.x #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add firstValues, readBooleans helpers * feat: export types * docs: document helpers * docs: fix example
* chore: up supertest jest and nyc * tests: convert to import , fix some tests * test: make malformed boundary as per comment ? * tests: refactor
Closed
tunnckoCore
reviewed
Oct 30, 2021
| parser.on('data', ({ key, value }) => { | ||
| this.emit('field', key, value); | ||
| parser.on('data', (fields) => { | ||
| this.fields = fields; |
There was a problem hiding this comment.
it should still emit field event
There was a problem hiding this comment.
it was done #760
if the json is just a number, or string it can't emit field with key value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#635