Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove depr. request #807

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

jimmywarting
Copy link
Collaborator

request have been deprecated for a long time...

I took one body/header example out and using it as a static fixture example instead

Allows to remove request and many sub modules

@GrosSacASac GrosSacASac merged commit 1618ea0 into node-formidable:master Jan 2, 2022
@jimmywarting jimmywarting deleted the rm-request branch January 2, 2022 17:59
@jimmywarting
Copy link
Collaborator Author

jimmywarting commented Jan 2, 2022

I'm curious about what the issue #46 really was about... was it the request fault or formidable that was too strict?
(how was it fixed?)

the body did look alright to me... but the content-type header struck out doe
multipart/related... haven't encounter that before. expected it to be multipart/form-data

@GrosSacASac
Copy link
Contributor

I assume it was fixed, but I don't really know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants