Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

Lock issue #480

Closed
Nowaker opened this issue Nov 2, 2017 · 7 comments
Closed

Lock issue #480

Nowaker opened this issue Nov 2, 2017 · 7 comments

Comments

@Nowaker
Copy link

Nowaker commented Nov 2, 2017

Something like gh is 123 --lock

@protoEvangelion
Copy link
Member

@Nowaker Could you send a PR for this?

I am working on the backlog and it will be a while before I will be able to get to this.

Sounds like a cool feature 😄

@protoEvangelion
Copy link
Member

Looks like this can be done cleanly with the newly add octokit api: https://octokit.github.io/rest.js/#octokit-routes-issues-lock

File location to add this would be here:

if (options.assign) {

The approach would be to add a new flag like --lock.

And do if (options.lock)...

@protoEvangelion protoEvangelion self-assigned this Oct 2, 2019
protoEvangelion pushed a commit to protoEvangelion/gh that referenced this issue Oct 2, 2019
This feature will allow you to lock issues and provide the reason for locking.
re node-gh#480
@protoEvangelion
Copy link
Member

protoEvangelion commented Oct 2, 2019

#687

protoEvangelion pushed a commit to protoEvangelion/gh that referenced this issue Nov 13, 2019
Allows for locking an issue and or adding a lock reason.

re node-gh#480
protoEvangelion pushed a commit to protoEvangelion/gh that referenced this issue Nov 13, 2019
Allows for locking an issue and or adding a lock reason.

re node-gh#480
@protoEvangelion
Copy link
Member

@Nowaker can you give this a go or provide feedback if this meets your needs? #687

@Nowaker
Copy link
Author

Nowaker commented Nov 13, 2019

@protoEvangelion I guess it would had met my need two years ago for sure. That need is long gone with the project I was working on. But still thanks, someone else will find a use for it, yay! 😀

@protoEvangelion
Copy link
Member

Ha sorry it took so long!

protoEvangelion pushed a commit that referenced this issue Nov 13, 2019
Allows for locking an issue and or adding a lock reason.

re #480
protoEvangelion pushed a commit that referenced this issue Nov 13, 2019
# [2.8.0](v2.7.1...v2.8.0) (2019-11-13)

### Features

* **issue:** add issue locking capability ([b9b8994](b9b8994)), closes [#480](#480)
@protoEvangelion
Copy link
Member

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants