fix: should check process.env

node-modules · Jun 12, 2016 · 1cefede · 1cefede
1 parent 7de27b7
commit 1cefede
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/lib/method.js b/lib/method.js
@@ -28,6 +28,14 @@ var method = module.exports = function mockMethod(obj, key, method) {
     delete obj[key];
   }
 
+  // set a flag that checks if it is mocked
+  var flag = cache.get(obj);
+  if (!flag) {
+    flag = new Set();
+    cache.set(obj, flag);
+  }
+  flag.add(key);
+
   // Can't not delete the property of process.env before node@4
   if (obj === process.env) {
     obj[key] = method;
@@ -41,13 +49,6 @@ var method = module.exports = function mockMethod(obj, key, method) {
     value: method
   });
 
-  // set a flag that checks if it is mocked
-  var flag = cache.get(obj);
-  if (!flag) {
-    flag = new Set();
-    cache.set(obj, flag);
-  }
-  flag.add(key);
 };
 
 /**

diff --git a/test/method-test.js b/test/method-test.js
@@ -229,6 +229,12 @@ describe('Mock check', function() {
     muk(obj, 'e', 2);
     assert.ok(muk.isMocked(obj, 'e'));
   });
+
+  it('should check process.env', function() {
+    muk(process.env, 'HOME', '/mockhome');
+    assert.equal(process.env.HOME, '/mockhome');
+    assert.ok(muk.isMocked(process.env, 'HOME'));
+  });
 });
 
 function hasOwnProperty(obj, prop) {