Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make load, setFlows async/await (enable vitest) #82

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

AllanOricil
Copy link
Contributor

This is a continuation of #81 to enable vitest as the test runner

Repro Steps

  1. clone https://github.com/AllanOricil/node-red-node-test-helper
  2. checkout branch vitest-setup-2
  3. npm install
  4. npm link
  5. clone https://github.com/AllanOricil/nrg-template
  6. checkout branch vitest
  7. npm run install
  8. npm link node-red-node-test-helper
  9. npm run test
  10. verify tests pass as displayed below
image

@AllanOricil
Copy link
Contributor Author

AllanOricil commented Nov 3, 2024

BEFORE

In the image below it is possible to see that I'm using the package without any of my changes

image

AFTER

All tests from node-red are still passing with these changes. In the image below it is possible to see that I linked my changes in the node-red repo before running tests with it.

image

Conclusion

These changes do not affect the current behavior of the test lib

@knolleary
Copy link
Member

Looks good - thanks!

@knolleary knolleary merged commit 949edd2 into node-red:master Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants