Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate dependency on CLDR and minor fix for WoT code generation #116

Merged
merged 3 commits into from
Sep 16, 2020
Merged

Eliminate dependency on CLDR and minor fix for WoT code generation #116

merged 3 commits into from
Sep 16, 2020

Conversation

k-toumura
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

  • Eliminate dependency on CLDR to shrink install footprint
  • Minor bug fix on URL template processing in WoT code generation

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@k-toumura k-toumura mentioned this pull request Sep 3, 2020
Open
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 65.278% when pulling d940867 on node-red-hitachi:fix-urltemplate into d914f7e on node-red:master.

@kazuhitoyokoi kazuhitoyokoi merged commit 9e6e4cc into node-red:master Sep 16, 2020
@kazuhitoyokoi
Copy link
Member

@k-toumura Thank you for your quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-toumura @coveralls @kazuhitoyokoi