Making proxy work #111
Merged
Making proxy work #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicola
commented
Aug 3, 2015
nicola
commented
- Proxy working
- basic test
- further tests
- make sure cors works on proxy requests
|
Interesting travis might have some proxy for external resources, this needs further testing |
| ldp.xssProxy = argv.xssProxy; | ||
| ldp.proxyFilter = regexp().start(ldp.xssProxy).toRegExp(); | ||
| ldp.proxy = argv.proxy; | ||
| ldp.proxyFilter = regexp().start(ldp.proxy).toRegExp(); |
There was a problem hiding this comment.
Quick question: what does proxyFilter do, and why do we need a filter for proxy?
There was a problem hiding this comment.
Good question, removing that variable. It created a regex based on ldp.proxy, however express handles paths as regexp already, so no need for that
|
r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.