fix e2e test #336
fix e2e test #336
Conversation
.github/actions/e2e/action.yml
Outdated
| @@ -143,3 +141,8 @@ runs: | |||
| shell: bash | |||
| run: docker compose -f test_resource/compose.yaml logs | |||
| if: ${{ always() }} | |||
|
|
|||
| - name: (run) show colima log | |||
There was a problem hiding this comment.
Random drops in 'colima', so I'll add it to check the log in case of future fail.
| @@ -37,7 +37,6 @@ runs: | |||
| pid=$(docker exec $container_id pgrep -f nodex-agent) | |||
| docker exec $container_id kill -SIGINT $pid | |||
| sleep 3 | |||
| if: ${{ always() }} | |||
There was a problem hiding this comment.
Remove sigint test because it is not necessary to add "always"
| platform: linux/amd64 | ||
| volumes: | ||
| - ./did_sidetree.yaml:/tmp/api.yaml:ro | ||
| ports: | ||
| - "4010:4010" | ||
| healthcheck: | ||
| # this docker image doens't have curl | ||
| test: wget --no-verbose --tries=1 --spider http://localhost:4010/health || exit 1 | ||
| test: ["CMD-SHELL", "curl -f http://localhost:4010/health || exit 1"] |
There was a problem hiding this comment.
It passes healthcheck for curl, but fails after several attempts with wget. I don't know why.
I have confirmed that prism is running fine even when wget fails.
| @@ -138,6 +138,31 @@ paths: | |||
| schema: | |||
| $ref: "#/components/schemas/Error" | |||
|
|
|||
| /v1/metric: | |||
There was a problem hiding this comment.
Added because there are many unnecessary request failure logs because the metric schema does not exist.
|
I checked the resources for this issue and everything seemed fine. |
test_resource/compose.yaml
Outdated
| # this docker image doens't have curl | ||
| test: wget --no-verbose --tries=1 --spider http://localhost:4010/health || exit 1 | ||
| test: ["CMD-SHELL", "curl -f http://localhost:4010/health || exit 1"] |
There was a problem hiding this comment.
Same here, # this docker image doens't have curl you can delete this comment if curl is installed manually ?
Fixed problem with e2e test crashing