Use nodex-didcomm #341
Merged
Use nodex-didcomm #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curry-like
force-pushed
the
feature/use-nodex-didcomm
branch
5 times, most recently
from
f9993a6 to
ef3a79a
Compare
curry-like
force-pushed
the
feature/use-nodex-didcomm
branch
from
fa11799 to
96986a9
Compare
da13da
reviewed
Jun 25, 2024
src/services/nodex.rs
Outdated
| std::process::Command::new(&agent_path) | ||
| .spawn() | ||
| .expect("Failed to execute command"); | ||
| Command::new(&agent_path).spawn()?; |
There was a problem hiding this comment.
I remember that if the code by the original deamonize is deleted, the information of the parent process is inherited, which causes a problem in the operation to stop other processes when the process is started by the update.
tzskp1
reviewed
Jun 26, 2024
There was a problem hiding this comment.
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -34,12 +34,11 @@ anyhow = "1.0.81"
arrayref = { version = "0.3.7" }
async-trait = { version = "0.1.80" }
base64 = { version = "0.22.0" }
-chrono = { version = "0.4" }
+chrono = { version = "0.4", features = ["serde"] }
clap = { version = "4.5.2", features = ["cargo", "derive"] }
cuid = { version = "1.3.2" }
daemonize = "0.5.0"
data-encoding = { version = "2.5.0" }
-didcomm-rs = { git = "https://github.com/nodecross/didcomm-rs.git", tag = "v0.8.0" }
digest = { version = "0.10.7" }
dirs = { version = "5.0.1" }
dotenvy = "0.15.7"I think that didcomm-rs is no longer needed.
| project_verifier: Box<dyn ProjectVerifier + Send + Sync + 'static>, | ||
| message_activity_repository: Box<dyn MessageActivityRepository + Send + Sync + 'static>, | ||
| didcomm_encrypted_service: DIDCommEncryptedService, | ||
| pub struct DidcommMessageUseCase<D: DidRepository> { |
There was a problem hiding this comment.
pub struct DidcommMessageUseCase<V, R, D, A>
where
V: ProjectVerifier,
R: MessageActivityRepository,
D: DidRepository,
A: DidAccessor,
{
project_verifier: V,
message_activity_repository: R,
didcomm_encrypted_service: DIDCommEncryptedService<D>,
did_accessor: A,
}
impl<V, R, D, A> DidcommMessageUseCase<V, R, D, A>
where
V: ProjectVerifier,
R: MessageActivityRepository,
D: DidRepository,
A: DidAccessor,
{
pub fn new(
project_verifier: V,
message_activity_repository: R,
didcomm_encrypted_service: DIDCommEncryptedService<D>,
did_accessor: A,
) -> Self {
DidcommMessageUseCase {
project_verifier,
message_activity_repository,
didcomm_encrypted_service,
did_accessor,
}
}
}I think you can avoid the Box::new idiom by doing the above.
(Maybe DIDCommEncryptedService should be a trait like below.)
#[async_trait::async_trait]
pub trait DIDCommEncryptedService {
...
}
#[async_trait::async_trait]
impl<R: DidRepository> DIDCommEncryptedService for R {
...
}
da13da
reviewed
Jul 8, 2024
Cargo.toml
Outdated
| clap = { version = "4.5.2", features = ["cargo", "derive"] } | ||
| colored = { version = "2" } | ||
| cuid = { version = "1.3.2" } | ||
| daemonize = "0.5.0" |
There was a problem hiding this comment.
Conflict has caused daemonize and nix to be unix-only dependencies and overall dependencies.
By removing daemonize and nix from the overall dependencies, I was able to successfully build on the actual device.
curry-like
force-pushed
the
feature/use-nodex-didcomm
branch
from
1ff7b85 to
fbbc7e6
Compare
da13da
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To simplify nodex, we want to use nodex-didcomm.
WARNING
This PR removed unused internal APIs. Please check them.