Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use OS CA certificate #357

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix: use OS CA certificate #357

merged 1 commit into from
Aug 1, 2024

Conversation

tzskp1
Copy link
Contributor

@tzskp1 tzskp1 commented Jul 28, 2024 •
edited
Loading

WHY

  • rustls does not use OS CA Cert.
  • This causes inconvenience when using https proxy with ssl bump.
    • Users must add CA Cert manually.

WHAT

  • Make rustls use OS CA Cert.

NOTE

@tzskp1 tzskp1 changed the title Add proxy test using self certified CA cert fix: use os CA certificate Jul 28, 2024
@tzskp1 tzskp1 force-pushed the fix/use-os-ca-cert branch 2 times, most recently from d059a5d to 878ef9d Compare July 29, 2024 01:15
@tzskp1 tzskp1 changed the title fix: use os CA certificate fix: use OS CA certificate Jul 29, 2024
@tzskp1 tzskp1 force-pushed the fix/use-os-ca-cert branch from b981035 to 9302048 Compare July 29, 2024 05:32
@tzskp1 tzskp1 force-pushed the fix/use-os-ca-cert branch from 984d23f to e6e2fcf Compare July 30, 2024 13:05
@tzskp1 tzskp1 marked this pull request as ready for review July 30, 2024 13:13
@tzskp1 tzskp1 requested a review from a team as a code owner July 30, 2024 13:13
@tzskp1 tzskp1 requested a review from curry-like July 30, 2024 13:13
@tzskp1 tzskp1 merged commit eef7059 into main Aug 1, 2024
14 checks passed
@tzskp1 tzskp1 deleted the fix/use-os-ca-cert branch August 1, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curry-like curry-like curry-like approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzskp1 @curry-like