Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/release deb #375

Merged
merged 33 commits into from
Sep 4, 2024
Merged

Chore/release deb #375

merged 33 commits into from
Sep 4, 2024

Conversation

da13da
Copy link
Contributor

@da13da da13da commented Aug 20, 2024

We have added a feature to release .deb packages using GitHub Actions.
The functionality has been verified using act for parts that do not rely on GitHub.

@da13da da13da changed the base branch from main to chore/packaging-deb-with-omnibus August 20, 2024 14:03
@da13da da13da marked this pull request as ready for review August 24, 2024 01:01
@da13da da13da requested a review from a team as a code owner August 24, 2024 01:01
@da13da da13da requested review from curry-like and removed request for a team August 24, 2024 01:01
- name: Upload asset (mac)
uses: ./.github/actions/upload-release-asset
with:
release_id: ${{ steps.release.outputs.result }}
asset_path: ${{ github.workspace }}/nodex-agent-aarch64-apple-darwin.zip
asset_name: nodex-agent-mac.zip
asset_content_type: application/zip
asset_content_type: application/vnd.debian.binary-package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I was specifying the wrong location. I've fixed it.

@da13da
Copy link
Contributor Author

da13da commented Aug 26, 2024

@curry-like
I would appreciate it if you could wait for a review for a while so that I can modify it to compile with cross.

Base automatically changed from chore/packaging-deb-with-omnibus to main August 29, 2024 13:49
@da13da da13da requested a review from curry-like September 2, 2024 10:36
@da13da
Copy link
Contributor Author

da13da commented Sep 2, 2024

When I do a cross build with act, the health check fails, although I don't know the cause.
So I checked with github action.
https://github.com/nodecross/nodex/actions/runs/10645001794/job/29510340783?pr=375

@da13da da13da merged commit 642ae13 into main Sep 4, 2024
14 checks passed
@da13da da13da deleted the chore/release-deb branch September 4, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants