Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows 10, nodejs 10.12.0 boxstarter dependency force reboot #369

Closed
danjo133 opened this issue Oct 13, 2018 · 5 comments
Closed

windows 10, nodejs 10.12.0 boxstarter dependency force reboot #369

danjo133 opened this issue Oct 13, 2018 · 5 comments

Comments

@danjo133
Copy link

danjo133 commented Oct 13, 2018 •
edited
Loading

When installing nodejs 10.12.0 from https://nodejs.org/dist/v10.12.0/node-v10.12.0-x64.msi the installer asks if the user wants to install some additional dependencies for nodejs modules containing c++-code.

This installs Boxstarter/Chocolatery which, out of the blue, force rebooted my computer with no warning, no option to save files or anything else. For me, it rebooted 4 times during install.

This is acceptable precisely never.
@vsemozhetbyt
Copy link

cc @nodejs/platform-windows and @joaocgreis @tniessen as per possibly related PRs:

nodejs/node#22645
nodejs/node#23003
nodejs/node#22988

@joaocgreis
Copy link
Member

Rebooting is essential to install those tools reliably. @danjo133 the fact that your machine rebooted 4 times is a strong indication that the installation would have failed if not allowed to reboot.

The script warns about this:
image

@XieJiSS
Copy link

XieJiSS commented Oct 20, 2018

Well it did warn, but I believe it's not noticeable enough, for many users simply press Enter or whatever when they see Press any key to continue....
Would it be possible to change the prompt from Press any key to continue... into Have you saved all your files and closed all open programs? (y/N)?

@XieJiSS XieJiSS mentioned this issue Oct 20, 2018
Closed
2 tasks
joaocgreis added a commit to JaneaSystems/node that referenced this issue Oct 31, 2018
@joaocgreis
win: add prompt to tools installation script
8aeb1a2 
Fixes: nodejs/Release#369
@joaocgreis joaocgreis mentioned this issue Oct 31, 2018
Closed
2 tasks
joaocgreis added a commit to JaneaSystems/node that referenced this issue Oct 31, 2018
@joaocgreis
win: add prompt to tools installation script
23c02c0 
Fixes: nodejs/Release#369
Trott pushed a commit to Trott/io.js that referenced this issue Nov 4, 2018
@joaocgreis @Trott
win: add prompt to tools installation script
ab2778d 
Fixes: nodejs/Release#369

PR-URL: nodejs#23987
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Nov 4, 2018
@ferventcoder @MylesBorins
win: clarify Boxstarter behavior on install tools
e9a2915 
Clarify the behavior of what Boxstarter may do when it runs on a box
to install all the necessary tools so that there are no surprises to
the end user when the script is run.

Currently there is no interface that warns the user that Boxstarter
will reboot the machine possibly multiple times depending on how many
dependencies need to be installed and doesn't mention a need to disable
UAC. For folks who see what may look like a reboot loop, we feel it is
necessary to make them aware that UAC will be disabled and they will
need to take action to re-enable UAC manually if they interfere/stop
the script from finishing.

PR-URL: #23987
Fixes: nodejs/Release#369
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Nov 4, 2018
@joaocgreis @MylesBorins
win: add prompt to tools installation script
257a5e9 
Fixes: nodejs/Release#369

PR-URL: #23987
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit to nodejs/node that referenced this issue Nov 5, 2018
@ferventcoder @targos
win: clarify Boxstarter behavior on install tools
df1ca0f 
Clarify the behavior of what Boxstarter may do when it runs on a box
to install all the necessary tools so that there are no surprises to
the end user when the script is run.

Currently there is no interface that warns the user that Boxstarter
will reboot the machine possibly multiple times depending on how many
dependencies need to be installed and doesn't mention a need to disable
UAC. For folks who see what may look like a reboot loop, we feel it is
necessary to make them aware that UAC will be disabled and they will
need to take action to re-enable UAC manually if they interfere/stop
the script from finishing.

PR-URL: #23987
Fixes: nodejs/Release#369
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit to nodejs/node that referenced this issue Nov 5, 2018
@joaocgreis @targos
win: add prompt to tools installation script
57a2b95 
Fixes: nodejs/Release#369

PR-URL: #23987
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@tdaniely

This comment has been minimized.

Sign in to view
@refack

This comment has been minimized.

Sign in to view
@refack refack mentioned this issue Nov 13, 2018
Merged
3 tasks
refack added a commit to refack/node that referenced this issue Nov 18, 2018
@refack
Revert "win,msi: install tools for native modules"
469473d 
This reverts:
	Revision: 257a5e9
	win: add prompt to tools installation script

	Revision: e9a2915
	win: clarify Boxstarter behavior on install tools

	Revision: 3b895d1
	win,msi: display license notes before installing tools

	Revision: cf284c8
	win,msi: install Boxstarter from elevated shell

	Revision: 2b7e18d
	win,msi: highlight installation of 3rd-party tools

	Revision: ebf36cd
	win,msi: install tools for native modules

PR-URL: nodejs#24344
Refs: nodejs#22645
Refs: nodejs#23987
Refs: nodejs/Release#369
Refs: nodejs#23838
Refs: nodejs/security-wg#439
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@AdamMajer AdamMajer mentioned this issue Nov 26, 2018
Closed
rvagg pushed a commit to nodejs/node that referenced this issue Nov 28, 2018
@ferventcoder @rvagg
win: clarify Boxstarter behavior on install tools
41e3e3b 
Clarify the behavior of what Boxstarter may do when it runs on a box
to install all the necessary tools so that there are no surprises to
the end user when the script is run.

Currently there is no interface that warns the user that Boxstarter
will reboot the machine possibly multiple times depending on how many
dependencies need to be installed and doesn't mention a need to disable
UAC. For folks who see what may look like a reboot loop, we feel it is
necessary to make them aware that UAC will be disabled and they will
need to take action to re-enable UAC manually if they interfere/stop
the script from finishing.

PR-URL: #23987
Fixes: nodejs/Release#369
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg pushed a commit to nodejs/node that referenced this issue Nov 28, 2018
@joaocgreis @rvagg
win: add prompt to tools installation script
3c2a872 
Fixes: nodejs/Release#369

PR-URL: #23987
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg pushed a commit to nodejs/node that referenced this issue Nov 28, 2018
@refack @rvagg
Revert "win,msi: install tools for native modules"
41be530 
This reverts:
	Revision: 257a5e9
	win: add prompt to tools installation script

	Revision: e9a2915
	win: clarify Boxstarter behavior on install tools

	Revision: 3b895d1
	win,msi: display license notes before installing tools

	Revision: cf284c8
	win,msi: install Boxstarter from elevated shell

	Revision: 2b7e18d
	win,msi: highlight installation of 3rd-party tools

	Revision: ebf36cd
	win,msi: install tools for native modules

PR-URL: #24344
Refs: #22645
Refs: #23987
Refs: nodejs/Release#369
Refs: #23838
Refs: nodejs/security-wg#439
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Nov 29, 2018
@ferventcoder @MylesBorins
win: clarify Boxstarter behavior on install tools
589f0d2 
Clarify the behavior of what Boxstarter may do when it runs on a box
to install all the necessary tools so that there are no surprises to
the end user when the script is run.

Currently there is no interface that warns the user that Boxstarter
will reboot the machine possibly multiple times depending on how many
dependencies need to be installed and doesn't mention a need to disable
UAC. For folks who see what may look like a reboot loop, we feel it is
necessary to make them aware that UAC will be disabled and they will
need to take action to re-enable UAC manually if they interfere/stop
the script from finishing.

PR-URL: #23987
Fixes: nodejs/Release#369
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Nov 29, 2018
@joaocgreis @MylesBorins
win: add prompt to tools installation script
5d17bf1 
Fixes: nodejs/Release#369

PR-URL: #23987
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Nov 29, 2018
@refack @MylesBorins
Revert "win,msi: install tools for native modules"
9e293c1 
This reverts:
	Revision: 257a5e9
	win: add prompt to tools installation script

	Revision: e9a2915
	win: clarify Boxstarter behavior on install tools

	Revision: 3b895d1
	win,msi: display license notes before installing tools

	Revision: cf284c8
	win,msi: install Boxstarter from elevated shell

	Revision: 2b7e18d
	win,msi: highlight installation of 3rd-party tools

	Revision: ebf36cd
	win,msi: install tools for native modules

PR-URL: #24344
Refs: #22645
Refs: #23987
Refs: nodejs/Release#369
Refs: #23838
Refs: nodejs/security-wg#439
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@refack @joaocgreis @danjo133 @tdaniely @vsemozhetbyt @XieJiSS