-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
problems with llhttp 9.x upgrades in v20.x #973
Comments
I wonder how nodejs/node#50080 could be cherry-picked cleanly to v20.x-staging. |
cc: @ShogunPanda We should flag all v9.x updates as dont-land-on-v20.x and dont-land-on-v18.x. There's just one update for v8.x (v8.1.1) and we didn't receive an automatic update for that. @UlisesGascon I think just dropping the commit from v20.x-staging and rebasing again should be enough. |
I was wondering the same, but now that I tried to cherry pick it again in staging.. I realised that I introduced the regression when I was solving the conflict in the
Yes, I dropped the commit and the versions in the binaries are as expected. So, as soon as the CI/CITGM is clear I will release the proposal. Next steps I will work in a backport for this, so it can be landed easier in the next release 👍 |
There's no need for a backport for that. It's a change that should exist only on v21.x and main since it's semver-major |
I agree. llhttp 9.1.2 was a breaking change which should not belong to v20.x. |
Seems like the issue was due a manual regression that I introduced (see). As the |
I created this issue for visibility, based on team slack discussion
When I was working on the release 20.11.0 proposal (step 10) I was checking the dependencies and I got an error with the
llhttp
version.I got the version
8.1.3
, but the expected is9.1.3
based on nodejs/node#50080 as was included in the proposal.The thing is that version
8.1.3
does not exist at all, as the current version is8.1.0
since Node@20.0.0. So, the issue is thatLLHTTP_VERSION_MAJOR
didn't got updated when cherry picking this commit, only theLLHTTP_VERSION_PATCH
.I added the label
dont-land-on-v20
for now. But this error will occur again when landing new deps upgrades forllhttp
inNode@20.x
. So maybe we can work on a backport for the next release20.11.0 Proposal dependencies
20.0.0 dependencies
The text was updated successfully, but these errors were encountered: