-
Notifications
You must be signed in to change notification settings - Fork 134
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Vote on primordials in error path (#1158)
* vote on primordials in the error path * vote from aduh95 * vote from targos * vote from MylesBorins * vote from Rich Trott * vote from Mary Marchini * vote from Matteo Collina * vote from Gireesh Punathil * vote from cjihrig * vote from jasnell * vote from Michael Dawson * vote from Robert Nagy * vote from RaisinTen * vote from RaisinTen * vote from RaisinTen * vote from Tobias Nießen * vote from richardlau * vote from richardlau * vote from Beth Griggs * vote from danielleadams * Add vote from Joyee Cheung * vote from BridgeAR * close vote and aggregate results * Add missing EOL * Add back Gireesh vote data Co-authored-by: Michaël Zasso <targos@protonmail.com> Co-authored-by: Myles Borins <mylesborins@github.com> Co-authored-by: Rich Trott <rtrott@gmail.com> Co-authored-by: Mary Marchini <mmarchini@netflix.com> Co-authored-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Gireesh Punathil <gpunathi@in.ibm.com> Co-authored-by: cjihrig <cjihrig@gmail.com> Co-authored-by: James M Snell <jasnell@gmail.com> Co-authored-by: Michael Dawson <mdawson@devrus.com> Co-authored-by: Robert Nagy <ronagy@icloud.com> Co-authored-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Tobias Nießen <tniessen@tnie.de> Co-authored-by: Richard Lau <rlau@redhat.com> Co-authored-by: Beth Griggs <bgriggs@redhat.com> Co-authored-by: Danielle Adams <adamzdanielle@gmail.com> Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
- Loading branch information
18 people
authored
Feb 23, 2022
1 parent
d6d858d
commit 8fcaf34
Showing
1 changed file
with
157 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| { | ||
| "description": "Do we want to make code in the error path tamper proof (and how tamper proof do we want it to be)?", | ||
| "refs": [ | ||
| "https://github.com/nodejs/TSC/pull/1158" | ||
| ], | ||
| "outcome": { | ||
| "winner(s)": [ | ||
| "Use primordials in the error path only if there are no significant perf regression." | ||
| ] | ||
| }, | ||
| "votes": { | ||
| "aduh95": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 1, | ||
| "Make the code in the error path full tamper proof by using primordials.": 2, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": -1, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 0, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": -2 | ||
| }, | ||
| "BethGriggs": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 1, | ||
| "Make the code in the error path full tamper proof by using primordials.": 1, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 1, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 3, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 3, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 3 | ||
| }, | ||
| "BridgeAR": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0, | ||
| "Make the code in the error path full tamper proof by using primordials.": 0, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 70, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 80, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 88 | ||
| }, | ||
| "cjihrig": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0, | ||
| "Make the code in the error path full tamper proof by using primordials.": 0, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 0, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 0 | ||
| }, | ||
| "danielleadams": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0, | ||
| "Make the code in the error path full tamper proof by using primordials.": 0, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 0, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 0 | ||
| }, | ||
| "gireeshpunathil": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 5, | ||
| "Make the code in the error path full tamper proof by using primordials.": 3, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 4, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 1, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 2, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 0 | ||
| }, | ||
| "jasnell": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": -1, | ||
| "Make the code in the error path full tamper proof by using primordials.": 0, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 0, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": -1, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": -1 | ||
| }, | ||
| "joyeecheung": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 3, | ||
| "Make the code in the error path full tamper proof by using primordials.": 1, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 2, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 2, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 0 | ||
| }, | ||
| "mcollina": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0, | ||
| "Make the code in the error path full tamper proof by using primordials.": 2, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 1, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 10, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 3, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 0 | ||
| }, | ||
| "mhdawson": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0, | ||
| "Make the code in the error path full tamper proof by using primordials.": 0, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 5, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 4 | ||
| }, | ||
| "mmarchini": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0, | ||
| "Make the code in the error path full tamper proof by using primordials.": 0, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 0, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 0 | ||
| }, | ||
| "MylesBorins": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0, | ||
| "Make the code in the error path full tamper proof by using primordials.": 0, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 0, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 0 | ||
| }, | ||
| "RaisinTen": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0, | ||
| "Make the code in the error path full tamper proof by using primordials.": -1, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0, | ||
| "Use primordials in the error path only if there are no significant perf regression.": -1, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 1, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 1 | ||
| }, | ||
| "richardlau": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 2, | ||
| "Make the code in the error path full tamper proof by using primordials.": 0, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 1, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 0 | ||
| }, | ||
| "ronag": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 3, | ||
| "Make the code in the error path full tamper proof by using primordials.": 0, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 1, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 2, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 4, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 5 | ||
| }, | ||
| "targos": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0, | ||
| "Make the code in the error path full tamper proof by using primordials.": 3, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 3, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 2, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 1, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 0 | ||
| }, | ||
| "tniessen": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": -1, | ||
| "Make the code in the error path full tamper proof by using primordials.": 0, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": -1, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 0, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": -1, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 0 | ||
| }, | ||
| "Trott": { | ||
| "Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0, | ||
| "Make the code in the error path full tamper proof by using primordials.": 0, | ||
| "Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0, | ||
| "Use primordials in the error path only if there are no significant perf regression.": 0, | ||
| "Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0, | ||
| "Don't use any primordials (and undo existing ones) in the error path.": 0 | ||
| } | ||
| } | ||
| } |