Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nominating @gibfahn to release team and Node 8 LTS Steward #350

Closed
MylesBorins opened this issue Sep 14, 2017 · 18 comments
Closed

Nominating @gibfahn to release team and Node 8 LTS Steward #350

MylesBorins opened this issue Sep 14, 2017 · 18 comments

Comments

@MylesBorins
Copy link
Contributor

@gibfahn has been active in the LTS working group both in planning and in managing some of the backports for 6.x and 4.x. He has my complete trust in being able to be the point person on releases and on managing the LTS release process for our upcoming 8.x LTS.

I'm volunteering to mentor Gibson through the process.

@nodejs/lts @nodejs/release
@mhdawson
Copy link
Member

+1 from me :)

@cjihrig
Copy link
Contributor

cjihrig commented Sep 14, 2017

+1

@Trott
Copy link
Member

Trott commented Sep 14, 2017

+1

Didn't we charter the Release/LTS working group? I'm not seeing it listed at https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md

@MylesBorins
Copy link
Contributor Author

Looks like we need a PR to add the release group. I figured it was good to bring it up here though. Can punt to LTS

@gibfahn
Copy link
Member

gibfahn commented Sep 14, 2017

According to the just-chartered Release WG Readme:

https://github.com/nodejs/LTS/blame/master/README.md#L53-L55

The releasers team is entrusted with the secrets and CI access to be able
build and sign releases. Additions to the releasers team must be approved
by the CTC.

@jasnell
Copy link
Member

jasnell commented Sep 14, 2017

Ping @nodejs/tsc ... Any objections to @gibfahn as a releaser?

@jasnell
Copy link
Member

jasnell commented Sep 14, 2017

Here's my +1

@evanlucas
Copy link
Contributor

+1 from me!

@thefourtheye
Copy link
Contributor

+1

5 similar comments
@targos
Copy link
Member

targos commented Sep 15, 2017

+1

@rvagg
Copy link
Member

rvagg commented Sep 15, 2017

👍

@mcollina
Copy link
Member

👍

@ofrobots
Copy link
Contributor

👍

@Fishrock123
Copy link
Contributor

+1

@jasnell
Copy link
Member

jasnell commented Sep 19, 2017

Given that there have been no objections, we should be able to consider this approved.

@MylesBorins
Copy link
Contributor Author

@gibfahn you are going to want to send a pr to the main repo with your gpg key

@fhinkel
Copy link
Member

fhinkel commented Oct 11, 2017 •
edited
Loading

+1 and closing. Looks like this happened 😄

@fhinkel fhinkel closed this as completed Oct 11, 2017
@MylesBorins
Copy link
Contributor Author

@gibfahn please ping me to schedule a time to be onboarded as a release manager. You can audit me doing 6.12.0 if you like 🗡

@gibfahn gibfahn mentioned this issue Oct 30, 2017
Closed
gibfahn added a commit to gibfahn/node that referenced this issue Oct 30, 2017
@gibfahn
doc: add Gibson Fahnestock to Release team
c3e2773 
Refs: nodejs/TSC#350
MylesBorins pushed a commit to nodejs/node that referenced this issue Oct 31, 2017
@gibfahn @MylesBorins
doc: add Gibson Fahnestock to Release team
46ca177 
PR-URL: #16620
Refs: nodejs/TSC#350
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Oct 31, 2017
@gibfahn @MylesBorins
doc: add Gibson Fahnestock to Release team
4d9c1be 
PR-URL: #16620
Refs: nodejs/TSC#350
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
jasnell pushed a commit to nodejs/node that referenced this issue Oct 31, 2017
@gibfahn @jasnell
doc: add Gibson Fahnestock to Release team
ed92e0c 
PR-URL: #16620
Refs: nodejs/TSC#350
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Nov 16, 2017
@gibfahn @MylesBorins
doc: add Gibson Fahnestock to Release team
c57fe60 
PR-URL: #16620
Refs: nodejs/TSC#350
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Nov 16, 2017
@gibfahn @MylesBorins
doc: add Gibson Fahnestock to Release team
acfc12c 
PR-URL: #16620
Refs: nodejs/TSC#350
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Nov 21, 2017
@gibfahn @MylesBorins
doc: add Gibson Fahnestock to Release team
590631b 
PR-URL: #16620
Refs: nodejs/TSC#350
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Nov 28, 2017
@gibfahn @MylesBorins
doc: add Gibson Fahnestock to Release team
732af9b 
PR-URL: #16620
Refs: nodejs/TSC#350
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Dec 7, 2017
@gibfahn @MylesBorins
doc: add Gibson Fahnestock to Release team
fadf854 
PR-URL: #16620
Refs: nodejs/TSC#350
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Dec 8, 2017
@gibfahn @MylesBorins
doc: add Gibson Fahnestock to Release team
af8a837 
PR-URL: #16620
Refs: nodejs/TSC#350
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Mar 28, 2018
@gibfahn @MylesBorins
doc: add Gibson Fahnestock to Release team
29b4972 
PR-URL: #16620
Refs: nodejs/TSC#350
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Mar 30, 2018
@gibfahn @MylesBorins
doc: add Gibson Fahnestock to Release team
9b9bb88 
PR-URL: #16620
Refs: nodejs/TSC#350
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests