Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add minutes for meeting 6 March 2024 #1515

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Mar 7, 2024

No description provided.

Signed-off-by: Michael Dawson <midawson@redhat.com>
@mcollina mcollina merged commit 39c2e4a into nodejs:main Mar 7, 2024
1 check passed
Copy link
Member

@GeoffreyBooth GeoffreyBooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This merged a bit fast, here are a few small corrections.

* Currently corepack requires a command line option to enable it, when
It is enabled, symlinks are added for pnpm and yarn, when you hit
those symlinks it downloads a version and runs it for you.
* PR removes the step of disabling. Instead the symlinks would be there
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should say “enabling”, not “disabling.”

* Don’t have enough doc, which package managers would we support, how do we decide which ones to add. Etc.
* Don’t have agreement on goals, etc.
* Some objections on ux perspective that npm is not supported, and npm does not support
package.json that corepack uses.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“package.json field”

Comment on lines +63 to +64
* objections concerns about jumper binary approach, one of the reasons why npm has opted
* npm opted to not be included in corepack since the beginning
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“one of the reasons why npm has opted not to be included in corepack since the beginning”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants