Reduce inactive collaborator duration #1540

github-actions · 2024-04-26T20:19:53Z

Currently, the bot looks through all commits on main that have landed in the last 12 months, and makes two lists:

a list of all the commit authors.
a list of all the collaborators who are listed as reviewers in the commit message (i.e. folks who have approved the PR).

The bot will open a PR to move a collaborator to emeritus if they don't appear in either of those lists.
This vote is to decide whether we want to reduce the timespan from 12 months to
9 months.

Vote instructions:

on the CLI: git node vote https://github.com/nodejs/TSC/pull/1540
on the web: https://nodejs.github.io/caritat/#https://github.com/nodejs/TSC/pull/1540

To close the vote, at least 3 secret holder(s)¹ must run the following command: git node vote https://github.com/nodejs/TSC/pull/1540 --decrypt-key-part --post-comment (N.B.: you should not add the --post-comment flag if the token you're using does not have permission to post comments)

/cc @nodejs/tsc

Current estimated participation: 100%

secret holders are folks who have access to the private key associated with a public key on hkps://keys.openpgp.org that references an email address listed on the TSC voting member list at the time of the opening of the vote. ↩

anonrig · 2024-04-29T23:44:42Z

@aduh95 FYI The GPG I use on Github is with different email, and voting doesn't work because my email address is Sentry's in the TSC list. Additionally, lack of core.editor on Git config crashes the voting.

joyeecheung · 2024-04-30T01:22:31Z

I voted from GitHub code spaces so it's unverified (I was just curious how am I supposed to use code spaces to push to a PR)

jasnell · 2024-04-30T01:27:37Z

I think I voted correctly

aduh95 · 2024-04-30T08:17:49Z

I think I voted correctly

FWIW the bot also thinks you voted correctly – otherwise it would show a red cross instead of a green tick next to your commit (and it would have posted a comment to notify you why the commit is rejected). I say think because it can't tell whether the encrypted data in your commit is valid YAML syntax.

GeoffreyBooth · 2024-04-30T19:34:06Z

The command line didn’t work for me either but I was able to vote via the web: https://nodejs.github.io/caritat/#https://github.com/nodejs/TSC/pull/1540

aduh95 · 2024-05-04T11:13:57Z

I would like to close this vote, and for this effect, I'm revealing my key part:

-----BEGIN SHAMIR KEY PART-----
j0/wS4x6g3kkocvc59kPw/b7op+B2Xsx0GK7Oo9pITIB
-----END SHAMIR KEY PART-----

targos · 2024-05-05T09:32:29Z

I would like to close this vote, and for this effect, I'm revealing my key part:

-----BEGIN SHAMIR KEY PART-----
jihJsg9qYSP92DW+a3AWV6+RN1TY8wNRagY8zea0gTET
-----END SHAMIR KEY PART-----

aduh95 · 2024-05-06T21:10:56Z

@mcollina, @RafaelGSS, @richardlau: can one of you reveal his key part so the ballots can be decrypted?

richardlau · 2024-05-07T13:09:25Z

I would like to close this vote, and for this effect, I'm revealing my key part:

-----BEGIN SHAMIR KEY PART-----
npeJt04f0dYDni3+v5W6XtMDAUVDDbXN03y6a55d8T8P
-----END SHAMIR KEY PART-----

github-actions · 2024-05-07T13:48:15Z

Election results

Subject: Reduce inactive collaborator duration
End date: 2024-05-07T13:48:14.258Z
Participation: 100%

Results

Winning candidate: Status quo: Keep the current inactive collaborator duration of 12 months

Table of results

Candidate	Number of won duels
Status quo: Keep the current inactive collaborator duration of 12 months	1
Reduce the inactive collaborator duration to 9 months	0

Voting data

Participants:

Anatoli Papirovski <apapirovski@mac.com>¹
Antoine du Hamel <duhamelantoine1995@gmail.com>²
Benjamin Gruenbaum <benjamingr@gmail.com>³
Chengzhong Wu <legendecas@gmail.com>⁴
Geoffrey Booth <webadmin@geoffreybooth.com>⁵
Gireesh Punathil <gpunathi@in.ibm.com>⁶
James M Snell <jasnell@gmail.com>⁷
Joyee Cheung <joyeec9h3@gmail.com>⁸
Matteo Collina <matteo.collina@gmail.com>⁹
Michael Dawson <midawson@redhat.com>¹⁰
Michaël Zasso <targos@protonmail.com>¹¹
Moshe Atlow <moshe@atlow.co.il>¹²
Paolo Insogna <paolo@cowtech.it>¹³
Rafael Gonzaga <rafael.nunu@hotmail.com>¹⁴
Richard Lau <rlau@redhat.com>¹⁵
Robert Nagy <ronagy@icloud.com>¹⁶
Ruben Bridgewater <ruben@bridgewater.de>¹⁷
Ruy Adorno <ruy@vlt.sh>¹⁸
Tobias Nießen <tniessen@tnie.de>¹⁹
Yagiz Nizipli <yagiz.nizipli@sentry.io>²⁰

Private key to decrypt ballots

Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Abstained. ↩
Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Voted for Reduce the inactive collaborator duration to 9 months. ↩
Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Abstained. ↩
Voted for Reduce the inactive collaborator duration to 9 months. ↩
Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Voted for Status quo: Keep the current inactive collaborator duration of 12 months. ↩
Voted for Reduce the inactive collaborator duration to 9 months. ↩

anonrig · 2024-05-07T13:53:54Z

@aduh95 Why does some votes have 1 or -1 on them and some of them has 1 or 0?

aduh95 · 2024-05-07T13:57:04Z

@anonrig It's whatever people have voted (Tobias even voted 12 and 9, amusingly enough)

GeoffreyBooth · 2024-05-07T14:49:42Z

@anonrig It’s whatever people have voted (Tobias even voted 12 and 9, amusingly enough)

How are such votes calculated? Would it be divided, so Tobias’ vote becomes 9/12 = 0.75 toward whichever option he preferred, rather than 1? Or is it just 12 > 9 so whichever option got 12 gets the full 1 vote?

aduh95 · 2024-05-07T15:29:30Z

@GeoffreyBooth it's the latter, as written on the vote ballot, only the order matters.

GeoffreyBooth · 2024-05-07T15:38:39Z

A nice improvement to the bot would be if the results comment could include the number and percentage of votes for each option.

nodejs-github-bot and others added 9 commits April 26, 2024 20:19

Initiate vote for "Reduce inactive collaborator duration"

8751abc

vote from targos

cf66952

Create tniessen.json

a9ec8ea

Create rn

15059fa

vote from aduh95

adf4b5b

vote

d56300c

Create jasnell.json

d992e16

geoffreybooth vote

cf998b0

vote from MoLow

fba0433

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

vote from Rafael Gonzaga

ffd5b7a

RafaelGSS force-pushed the votes/1415d109-3ebc-4ee8-b3c3-a3b2a62ea033 branch from 03cddec to ffd5b7a Compare April 28, 2024 19:26

richardlau and others added 3 commits April 29, 2024 12:43

vote from richardlau

217399f

vote from mhdawson

c61030f

Create ShogunPanda.json

c7612fe

This comment was marked as resolved.

Sign in to view

legendecas and others added 2 commits April 30, 2024 05:38

vote from legendecas

ce74686

vote from anonrig

8e32ad8

This comment was marked as resolved.

Sign in to view

add vote from joyee

b47f46a

This comment was marked as resolved.

Sign in to view

ruyadorno and others added 2 commits April 29, 2024 22:40

vote from ruyadorno

2a2b219

vote from gireeshpunathil

2a26d19

This comment was marked as resolved.

Sign in to view

apapirovski and others added 3 commits April 30, 2024 21:37

vote from apapirovski

4049b97

vote from mcollina

224c2f8

vote from BridgeAR

4917012

close vote and aggregate results

394c21e

Delete rn

30fe040

richardlau approved these changes May 7, 2024

View reviewed changes

anonrig approved these changes May 7, 2024

View reviewed changes

aduh95 approved these changes May 7, 2024

View reviewed changes

aduh95 merged commit cac20cc into main May 7, 2024
1 check failed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce inactive collaborator duration #1540

Reduce inactive collaborator duration #1540

github-actions bot commented Apr 26, 2024 •

edited by aduh95

Loading

This comment was marked as outdated.

This comment was marked as resolved.

This comment was marked as resolved.

anonrig commented Apr 29, 2024

This comment was marked as resolved.

joyeecheung commented Apr 30, 2024 •

edited

Loading

jasnell commented Apr 30, 2024

This comment was marked as resolved.

aduh95 commented Apr 30, 2024

This comment was marked as resolved.

GeoffreyBooth commented Apr 30, 2024

aduh95 commented May 4, 2024

targos commented May 5, 2024

aduh95 commented May 6, 2024

richardlau commented May 7, 2024

github-actions bot commented May 7, 2024

anonrig commented May 7, 2024

aduh95 commented May 7, 2024

GeoffreyBooth commented May 7, 2024

aduh95 commented May 7, 2024

GeoffreyBooth commented May 7, 2024 •

edited

Loading

Reduce inactive collaborator duration #1540

Reduce inactive collaborator duration #1540

Conversation

github-actions bot commented Apr 26, 2024 • edited by aduh95 Loading

Footnotes

This comment was marked as outdated.

This comment was marked as resolved.

This comment was marked as resolved.

anonrig commented Apr 29, 2024

This comment was marked as resolved.

joyeecheung commented Apr 30, 2024 • edited Loading

jasnell commented Apr 30, 2024

This comment was marked as resolved.

aduh95 commented Apr 30, 2024

This comment was marked as resolved.

GeoffreyBooth commented Apr 30, 2024

aduh95 commented May 4, 2024

targos commented May 5, 2024

aduh95 commented May 6, 2024

richardlau commented May 7, 2024

github-actions bot commented May 7, 2024

Election results

Results

Table of results

Voting data

Footnotes

anonrig commented May 7, 2024

aduh95 commented May 7, 2024

GeoffreyBooth commented May 7, 2024

aduh95 commented May 7, 2024

GeoffreyBooth commented May 7, 2024 • edited Loading

github-actions bot commented Apr 26, 2024 •

edited by aduh95

Loading

joyeecheung commented Apr 30, 2024 •

edited

Loading

GeoffreyBooth commented May 7, 2024 •

edited

Loading