Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update TSC charter #698

Merged
merged 8 commits into from
Jul 10, 2019
Merged

doc: update TSC charter #698

merged 8 commits into from
Jul 10, 2019

Conversation

mhdawson
Copy link
Member

Update TSC charter to reflect merged OpenJS foundation.

This cannot land until approved by the Board. (I think we need one final board approval and then subsequent approvals would be by the by the CPC?)

Update TSC charter to reflect merged OpenJS foundation.
TSC-Charter.md Outdated Show resolved Hide resolved
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the section number updates.

@mhdawson
Copy link
Member Author

@mcollina fixed section numbering.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

These changes will need to be approved by either CPC or the board.

@Trott
Copy link
Member

Trott commented May 13, 2019

These changes will need to be approved by either CPC or the board.

How/when do we get clarity on which one deals with charter updates for the Node.js TSC?

@Trott
Copy link
Member

Trott commented May 13, 2019

These changes will need to be approved by either CPC or the board.

How/when do we get clarity on which one deals with charter updates for the Node.js TSC?

Oh, never mind, I see. Currently, it's the Node.js Board, but this changes it to the CPC. I would argue that this absolutely needs approval by both, not one or the other. (You can't take oversight away from the board without their approval.)

TSC-Charter.md Outdated Show resolved Hide resolved
TSC-Charter.md Outdated Show resolved Hide resolved
TSC-Charter.md Outdated Show resolved Hide resolved
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor corrections applied

mhdawson and others added 3 commits May 16, 2019 08:34
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@MylesBorins
Copy link
Contributor

Taken to the board and no one had concerns. We did not pass any motion or official approval, as this is something that should be done by the CPC.

Added the appropriate label.

@mhdawson will your tool be able to get labels from multiple orgs?

@mhdawson
Copy link
Member Author

@MylesBorins I don't think it is going to cross orgs.

@mhdawson
Copy link
Member Author

@kborchers pushed commit to address all of your comments.

@Trott
Copy link
Member

Trott commented Jun 11, 2019

@kborchers pushed commit to address all of your comments.

Technically, I imagine this means the board must re-approve it. In practice, I imagine they'd rather not be bothered about essentially cosmetic changes. So... ¯\(ツ)

@MylesBorins
Copy link
Contributor

MylesBorins commented Jun 11, 2019 via email

Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TSC-Charter.md Outdated Show resolved Hide resolved
TSC-Charter.md Outdated Show resolved Hide resolved
mhdawson and others added 2 commits June 19, 2019 17:28
Co-Authored-By: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Co-Authored-By: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
the same person. The TSC shall hold annual elections to select a TSC
Chairperson and Director; there are no limits on the number of terms a
TSC Chairperson or Director may serve.
work on building an agenda for TSC meetings and a OpenJS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an Impact project, Node.js has two voting members in CPC https://github.com/openjs-foundation/cross-project-council#impact-project-representatives

Should this be changed to two voting members?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trivikr no. The TSC only elects one of the two members. The second member is elected by the CommComm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

be specified by the Board relating to the intake and license compliance
review of contributions, including the Node.js Foundation IP Policy.
be specified by the OpenJS Foundation Board relating to the intake and license compliance
review of contributions, including the OpenJS Foundation IP Policy.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an OpenJS Foundation IP Policy currently defined? If so, can this link to it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianwarner is there a link for that?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhdawson and @Jonahss - I'm working on getting these various documents updated. I think it's best to leave it blank for now, and I'll be back with a link once we have something final which we can link.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this should land once we get the governance update landed (7 days from now) and then we can open a PR once the links are ready.

@sam-github
Copy link
Contributor

This has been on TSC agenda for 2 months (less 2 days), does it still need to be? I'm prepping for the upcoming meeting, and its not clear what needs to be discussed, since this has 9 approvals, and I don't see any dissent.

@mhdawson
Copy link
Member Author

mhdawson commented Jul 9, 2019

It's just waiting for approval by the CPC, but it does not necessarily need to be on the TSC agenda.

@MylesBorins
Copy link
Contributor

CPC had consensus last meeting. Governance for charter updates have landed and as such this is good to land

@MylesBorins MylesBorins merged commit 8434fa1 into nodejs:master Jul 10, 2019
@sam-github
Copy link
Contributor

Removing from agenda because it was discussed in #731, but anyone can add the label back on if it needs to come up again.

@mhdawson mhdawson deleted the updateGov branch August 14, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.