Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to address N-API versioning scheme #231

Closed
aruneshchandra opened this issue Apr 14, 2017 · 2 comments
Closed

Need to address N-API versioning scheme #231

aruneshchandra opened this issue Apr 14, 2017 · 2 comments
Assignees
@mhdawson
Milestone
Milestone 8

Comments

@aruneshchandra
Copy link
Contributor

No description provided.

@mhdawson mhdawson self-assigned this Apr 27, 2017
@mhdawson
Copy link
Member

Will take this on once the doc lands.

@jasongin jasongin added this to the Milestone 7 (Blog Readiness) milestone Apr 27, 2017
@mhdawson
Copy link
Member

Looking at this today. I think we have enough flexibility in how we load the N-API modules that we can introduce any module version checking later on without affecting exsting modules, if this ever needed. Hopefully not.

The only thing missing seems to be a method for an addon to be able to check the level of N-API being supported.

mhdawson added a commit to mhdawson/io.js that referenced this issue May 24, 2017
@mhdawson
n-api: add napi_get_version
a1c224c 
Add napi_get_version function so that addons can
query the level of N-API supported.

Fixes: nodejs/abi-stable-node#231
@mhdawson mhdawson mentioned this issue May 24, 2017
Closed
4 tasks
jasnell pushed a commit to nodejs/node that referenced this issue May 28, 2017
@mhdawson @jasnell
n-api: add napi_get_version
45139e5 
Add napi_get_version function so that addons can
query the level of N-API supported.

PR-URL: #13207
Fixes: nodejs/abi-stable-node#231
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 10, 2018
@mhdawson
n-api: add napi_get_version
5c0c021 
Add napi_get_version function so that addons can
query the level of N-API supported.

PR-URL: nodejs#13207
Fixes: nodejs/abi-stable-node#231
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Apr 16, 2018
@mhdawson @MylesBorins
n-api: add napi_get_version
86c0ebf 
Add napi_get_version function so that addons can
query the level of N-API supported.

Backport-PR-URL: #19447
PR-URL: #13207
Fixes: nodejs/abi-stable-node#231
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhdawson mhdawson

Labels
None yet
Projects
None yet
Milestone
Milestone 8
Development

No branches or pull requests
3 participants
@mhdawson @aruneshchandra @jasongin