-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request to move the refack/GYP repo to the org #247
Comments
Link: https://github.com/refack/GYP This sounds good to me. Ideally, I'd like to see node-gyp move to gyp.js, thus not requiring Python at all. I realize that this will require some more work, so for now being able to easily fix issues in gyp would be great. |
SGTM. Until we make a decision on the build system we want to switch to (or even if we want to switch to a new one), the current status is that we will have to maintain a fork of GYP anyways. Also, thanks for all the work you put into maintaining the GYP stuff! |
Sgtm |
sgtm
Il giorno ven 19 ott 2018 alle ore 15:00 James M Snell <
notifications@github.com> ha scritto:
… Sgtm
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#247 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADL41ZVguWNabrGscGyQ1vXuWJAhZ1Sks5umczTgaJpZM4Xtk5Y>
.
|
Sgtm |
1 similar comment
Sgtm |
This can go ahead. as per https://github.com/nodejs/admin/blob/master/GITHUB_ORG_MANGEMENT_POLICY.md#repositories
|
Thanks, I'm setting things up, and will try to follow up in the next few days. |
What happened to this? 🤔 |
What happened? +1 |
It seems the remaining support Google was providing for GYP has ended (CI doesn't work anymore, and the last contributor is not responding), so I request to move a forked repo to the org.
This will facilitate current efforts to make GYP python3 compatible (nodejs/node-gyp#1335, nodejs/node-gyp#1150, nodejs/node#23669, gyp-developer/ivg8pfDSrr0), as well as bug fixes and adaptation to new toolchain versions. Most importantly I want to revive GYP's CI test suite so we could have decent coverage of our current and future floating patches.
My assumption is that first and foremost this will help alleviate
node-gyp
pain points. Following that I have several ideas for improvements:.gyp
files (make it easier to maintain)IMHO coordinating such efforts requires the umbrella of an organization such ours, since bootstrapping a personal fork (especially one that is diverging from Google, and not explicitly affiliated with Node.js) is very challenging.
/CC @nodejs/gyp @node-gyp @nodejs/build @nodejs/build-files @nodejs/python
The text was updated successfully, but these errors were encountered: