Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request to move the refack/GYP repo to the org #247

Closed
refack opened this issue Oct 18, 2018 · 10 comments
Closed

request to move the refack/GYP repo to the org #247

refack opened this issue Oct 18, 2018 · 10 comments

Comments

@refack
Copy link
Contributor

refack commented Oct 18, 2018

It seems the remaining support Google was providing for GYP has ended (CI doesn't work anymore, and the last contributor is not responding), so I request to move a forked repo to the org.
This will facilitate current efforts to make GYP python3 compatible (nodejs/node-gyp#1335, nodejs/node-gyp#1150, nodejs/node#23669, gyp-developer/ivg8pfDSrr0), as well as bug fixes and adaptation to new toolchain versions. Most importantly I want to revive GYP's CI test suite so we could have decent coverage of our current and future floating patches.

My assumption is that first and foremost this will help alleviate node-gyp pain points. Following that I have several ideas for improvements:

  1. automating GYP-GN cross-compatibility
  2. static analysis and debugging tools to .gyp files (make it easier to maintain)
  3. build time optimizations (such as whole library caching, since only tools at this level have knowledge of all the inputs and variables used when building a library as a whole)
  4. adapting to new features in existing toolchains.

IMHO coordinating such efforts requires the umbrella of an organization such ours, since bootstrapping a personal fork (especially one that is diverging from Google, and not explicitly affiliated with Node.js) is very challenging.

/CC @nodejs/gyp @node-gyp @nodejs/build @nodejs/build-files @nodejs/python

@joaocgreis
Copy link
Member

Link: https://github.com/refack/GYP

This sounds good to me. Ideally, I'd like to see node-gyp move to gyp.js, thus not requiring Python at all. I realize that this will require some more work, so for now being able to easily fix issues in gyp would be great.

@joyeecheung
Copy link
Member

SGTM. Until we make a decision on the build system we want to switch to (or even if we want to switch to a new one), the current status is that we will have to maintain a fork of GYP anyways.

Also, thanks for all the work you put into maintaining the GYP stuff!

@jasnell
Copy link
Member

jasnell commented Oct 19, 2018

Sgtm

@mcollina
Copy link
Member

mcollina commented Oct 19, 2018 via email

@targos
Copy link
Member

targos commented Oct 19, 2018

Sgtm

1 similar comment
@mhdawson
Copy link
Member

Sgtm

@richardlau
Copy link
Member

This can go ahead. as per https://github.com/nodejs/admin/blob/master/GITHUB_ORG_MANGEMENT_POLICY.md#repositories

  • Transferring a repository into or out of the organization

Provided there are no objections from any TSC or CommComm members raised in the issue, such requests are approved automatically after 72 hours.

@refack
Copy link
Contributor Author

refack commented Nov 1, 2018

Thanks, I'm setting things up, and will try to follow up in the next few days.

@Croydon
Copy link

Croydon commented Jun 20, 2019

What happened to this? 🤔

@sinloss
Copy link

sinloss commented Jun 27, 2019

What happened? +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants