Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add social-team.md #494

Merged
merged 18 commits into from
Apr 28, 2020
Merged

docs: add social-team.md #494

merged 18 commits into from
Apr 28, 2020

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Apr 15, 2020

This PR adds the foundation for the Social Team, addressing #454. Took a few more "next week"s than I'd anticipated, but here it is 🙇

@bnb bnb self-assigned this Apr 15, 2020
@bnb
Copy link
Contributor Author

bnb commented Apr 15, 2020

since this affects both the TSC and CommComm:

@nodejs/tsc @nodejs/community-committee

❤️

social-team.md Outdated Show resolved Hide resolved
Co-Authored-By: Richard Lau <riclau@uk.ibm.com>
social-team.md Outdated Show resolved Hide resolved
social-team.md Outdated Show resolved Hide resolved
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few suggestions

Copy link
Member

@ahmadawais ahmadawais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ✔︎

Copy link
Contributor

@WaleedAshraf WaleedAshraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 🎉

@Trott
Copy link
Member

Trott commented Apr 19, 2020

Sorry to be late to this party, but should there be annual recertification like we do for Moderation Team? That has been really good for removing inactive members, IMO.

@bnb
Copy link
Contributor Author

bnb commented Apr 20, 2020

@Trott that sounds like an excellent idea to me. Added almost verbatim section to what Moderation uses.

@bnb
Copy link
Contributor Author

bnb commented Apr 23, 2020

I'll give this until Monday before merging since it is a relatively impactful change that does add a non-trivial set of work to the project. If there are no -1s and any further responses are able to be addressed by Monday, I'm going to merge.

Again, one last ping to @nodejs/tsc and @nodejs/community-committee for eyes ❤️

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bnb
Copy link
Contributor Author

bnb commented Apr 27, 2020

As a final heads up, going to merge this today @nodejs/community-committee @nodejs/tsc pending any -1s.

Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Member

@obensource obensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnb Just a few readability fixes. Otherwise, looks great (thus approved)! 😎

Thanks a million for kicking this off! 🚀

social-team.md Outdated Show resolved Hide resolved
social-team.md Outdated Show resolved Hide resolved
social-team.md Outdated Show resolved Hide resolved
social-team.md Outdated Show resolved Hide resolved
social-team.md Outdated Show resolved Hide resolved
social-team.md Outdated Show resolved Hide resolved
social-team.md Outdated Show resolved Hide resolved
social-team.md Outdated Show resolved Hide resolved
social-team.md Outdated Show resolved Hide resolved
social-team.md Outdated Show resolved Hide resolved
bnb and others added 3 commits April 28, 2020 11:35
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
bnb and others added 8 commits April 28, 2020 11:40
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
@bnb
Copy link
Contributor Author

bnb commented Apr 28, 2020

Given that those changes were readability nits that don't meaningfully change the contents and @obensource approved, I'm going to merge this. Thank you all for your feedback - excited to see this move forward ❤️

I'll be working with @rginn on getting the auth for the accounts to the Social Team as appropriate 👍

@bnb bnb merged commit db174b0 into master Apr 28, 2020
@bnb bnb deleted the bnb/add-social-team branch April 28, 2020 16:38
@obensource
Copy link
Member

🎉🎉🎉 Thanks for making this happen @bnb! 👏👏👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.