Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document typescript version #10

Closed
marco-ippolito opened this issue Jul 24, 2024 · 9 comments · Fixed by #12
Closed

document typescript version #10

marco-ippolito opened this issue Jul 24, 2024 · 9 comments · Fixed by #12

Comments

@marco-ippolito
Copy link
Member

marco-ippolito commented Jul 24, 2024

We need to document the supported latest typescript version.
maybe we can get it from swc @kdy1

@kdy1
Copy link
Member

kdy1 commented Jul 25, 2024

All TypeScript features except the stage 3 decorator proposal are supported, so SWC supports 5.5.4 for now. We will always implement the support the latest TypeScript before it's published.

@marco-ippolito
Copy link
Member Author

All TypeScript features except the stage 3 decorator proposal are supported, so SWC supports 5.5.4 for now. We will always implement the support the latest TypeScript before it's published.

Is it possible to add this information somewhere in the package, so when we update swc we can read it and update it?

@kdy1
Copy link
Member

kdy1 commented Jul 25, 2024

swc-project/swc#9334 adds the supported TypeScript version to the @swc/wasm-typescript package. The next stable version will have it documented in README.md

kdy1 added a commit to swc-project/swc that referenced this issue Jul 25, 2024
@marco-ippolito
Copy link
Member Author

marco-ippolito commented Jul 25, 2024

we changed the way we interact with swc, we now get the source code from the release and build it ourself, as per node policy, so we technically dont use the @swc/wasm-typescript per se.
Every new release we update the sourcecode in https://github.com/nodejs/amaro/tree/main/deps/swc
And compile it with rust following the same release pipeline. Per node policy we must keep the source code of our dependencies and build artifacts ourselves

@kdy1
Copy link
Member

kdy1 commented Jul 25, 2024

So do you prefer documenting it in the main README.md?

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Jul 25, 2024

No I mean, we use swc ./scripts/build.sh to generate the wasm file, if the README was inside that pkg output would be great, or wherever it is inside the project we can pull it in

RUN ./scripts/build.sh

@kdy1
Copy link
Member

kdy1 commented Jul 25, 2024

The README file lives at bindings/binding_typescript_wasm/README.md so it will be pulled.

https://github.com/swc-project/swc/tree/66f31c0af46dea60c51e4155a8887a5d2b441da3/bindings/binding_typescript_wasm

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Jul 25, 2024

I had a look in the release source.tar.gz https://github.com/swc-project/swc/releases/tag/v1.7.1 and the README is missing

@kdy1
Copy link
Member

kdy1 commented Jul 25, 2024

Oops, publish action for 1.7.2 failed. https://github.com/swc-project/swc/actions/runs/10089340507/job/27896627211
I'll fix it right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants