Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency list #49

Closed
marco-ippolito opened this issue Aug 8, 2024 · 6 comments · Fixed by nodejs/node#54462
Closed

Dependency list #49

marco-ippolito opened this issue Aug 8, 2024 · 6 comments · Fixed by nodejs/node#54462

Comments

@marco-ippolito
Copy link
Member

marco-ippolito commented Aug 8, 2024

This is the list of dependencies license used by the swc version we use:
https://github.com/nodejs/amaro/blob/4ffa2cd096ba273e84521657d8a6cf92958f31cc/deny.toml#L7C1-L20C2

[licenses]
allow = [
    "Apache-2.0",
    "Apache-2.0 WITH LLVM-exception",
    "MIT",
    "MPL-2.0",
    "BSD-3-Clause",
    "BSD-2-Clause",
    "ISC",
    "0BSD",
    "CC0-1.0",
    "Unicode-DFS-2016",
    "BSL-1.0"
]

This list is checked by cargo deny, and they might be dev dependencies.
Note that we bundle swc in a wasm file.

In nodejs/node we only added amaro license https://github.com/nodejs/node/pull/53725/files#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7R133-R157

ping @nodejs/tsc as fyi

@targos
Copy link
Member

targos commented Aug 8, 2024

We definitely need to add at least the swc license to node, since we distribute it in "Object form" (the wasm file).
Refs: https://github.com/swc-project/swc/blob/main/LICENSE

@targos
Copy link
Member

targos commented Aug 8, 2024

In fact, amaro should do it as well (in the npm package).

@marco-ippolito
Copy link
Member Author

In fact, amaro should do it as well (in the npm package).

so we should add in the dist folder of the npm package https://www.npmjs.com/package/amaro?activeTab=code, the license of swc?

@targos
Copy link
Member

targos commented Aug 9, 2024

I think so.

@marco-ippolito
Copy link
Member Author

we got swc license (which was not being included), I need to add it in the released bundle

@marco-ippolito
Copy link
Member Author

as soon as swc releases their updated license (I sent a PR swc-project/swc#9417) I will add it to the dist

RafaelGSS pushed a commit to nodejs/node that referenced this issue Aug 25, 2024
PR-URL: #54462
Fixes: nodejs/amaro#49
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Aug 30, 2024
PR-URL: #54462
Fixes: nodejs/amaro#49
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants