-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency list #49
Comments
We definitely need to add at least the |
In fact, |
so we should add in the |
I think so. |
we got swc license (which was not being included), I need to add it in the released bundle |
as soon as swc releases their updated license (I sent a PR swc-project/swc#9417) I will add it to the dist |
PR-URL: #54462 Fixes: nodejs/amaro#49 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
PR-URL: #54462 Fixes: nodejs/amaro#49 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
This is the list of dependencies license used by the
swc
version we use:https://github.com/nodejs/amaro/blob/4ffa2cd096ba273e84521657d8a6cf92958f31cc/deny.toml#L7C1-L20C2
This list is checked by cargo deny, and they might be dev dependencies.
Note that we bundle swc in a wasm file.
In nodejs/node we only added amaro license https://github.com/nodejs/node/pull/53725/files#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7R133-R157
ping @nodejs/tsc as fyi
The text was updated successfully, but these errors were encountered: