Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove exports #19

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: remove exports #19

merged 1 commit into from
Jul 29, 2024

Conversation

marco-ippolito
Copy link
Member

Fixes: #16

Copy link

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
But why not have specify export ?

@marco-ippolito
Copy link
Member Author

LGTM ! But why not have specify export ?

what else do we need to export other then main entrypoint?

@marco-ippolito marco-ippolito merged commit 418097c into main Jul 29, 2024
3 checks passed
@marco-ippolito marco-ippolito deleted the feat/fix-exports branch July 29, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

index is not specified in exports
2 participants