-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install h2load on benchmarking machine #1147
Comments
It's in the infra group. I've added the keys you have in GitHub onto the host so you can get in (maybe you should remove the one you don't need from there). Try to avoid the work if you see it working on any benchmarking tasks. |
I do have an action to add keys specific to the benchmarking WG onto those machines but I have just never had time to get to it. I added a comment to #1147 so if we ever get around to the ansible scripts we don't forget to add to the list of ones that should be installed. There are 3 benchmarking machines now, the original one and the 2 new ones from Intel. Its the 2 Intel ones that run the microbenchmarks job so we need to install on both of those. |
Anything I can help with here? It would be nice to have the benchmarking machine available for nodejs/node#18936. :) |
@maclover7 you still planning to get to this ? |
Fixes: nodejs#868 Fixes: nodejs#1147
@nodejs/build Ping – this just came up for nodejs/node#20084, and I think it’s somewhat important… again, if I can help with something, let me know. |
Hm … gentle ping @nodejs/build again :) |
@addaleax have you installed this before. I was looking to see if it as simple as installing with apt-get but all of the instructions I can find require building along with http2 and doing a full install of http2. |
@mhdawson What I did locally was building directly from a https://github.com/nghttp2/nghttp2 checkout and installing it (maybe even manually |
Sorry for not getting back to this. This is already in progress via #1171, just haven't had time to get back to it. Will take a look now |
Fixes: nodejs#868 Fixes: nodejs#1147 Creates a new `benchmarking` Ansible role, and runs for all machines with the `is_benchmark` machine variable set to `true`. Included `infra-softlayer-ubuntu1404-x64-2` since it is also a benchmark machine, in addition to `test-nearform_intel-ubuntu1604-x64-1` and `x64-2`.
Fixes: #868 Fixes: #1147 Creates a new `benchmarking` Ansible role, and runs for all machines with the `is_benchmark` machine variable set to `true`. Installs `h2load` utility package. Included `infra-softlayer-ubuntu1404-x64-2` since it is also a benchmark machine, in addition to `test-nearform_intel-ubuntu1604-x64-1` and `x64-2`.
Hey, I think I remember a similar issue being opened about one of the other benchmarkers, but I can’t find it right now. Anyway, it would be nice to have
h2load
installed on the benchmarking machine so that we can run the HTTP/2 benchmarks there?Otherwise the result is something like https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/128/console
The text was updated successfully, but these errors were encountered: