Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake on CITGM infrastructure #2097

Closed
BridgeAR opened this issue Dec 17, 2019 · 10 comments
Closed

cmake on CITGM infrastructure #2097

BridgeAR opened this issue Dec 17, 2019 · 10 comments
Labels

Comments

@BridgeAR
Copy link
Member

Some modules partially use cmake and seem to fail due to the lack of it on our infrastructure.

Would it be possible to add cmake to fix that?

@targos
Copy link
Member

targos commented Dec 17, 2019

Refs: nodejs/citgm#770

@rolftimmermans
Copy link

I'm a maintainer of zeromq.js and we use CMake to build the node add-on. Is there any way I can assist to get CMake added to the build systems/images?

@sam-github
Copy link
Contributor

If the machines have a working registry system (yum, apt, brew), and that system has a sufficiently up-to-date cmake, then this should be not too difficult, but like all things build, it takes a bit of legwork:

  • List affected jobs: ...
  • List affected build workers: ...
  • List what version of cmake is available, if any, on their OS level: ...
  • List exact name of the package (per host), and add it to the relevant ansible yml file: ...
  • Run ansible on each of the hosts to install cmake
  • Trigger builds of all affected jobs (see)

@rolftimmermans We don't onboard people into build very quickly because of the amount of root privs in CI it gives, but much of the work above doesn't require any privileges.

If someone took this to the stage where I just had to run ansible-playbook on a PR they put together, I'd find an hour to do that, but otherwise, I'm working on a few other build tasks ATM and won't have time to start this. Someone else might have time.

@richardlau
Copy link
Member

We do have some machines with cmake installed as we have two running libuv jobs:

I haven't looked (yet) at how those jobs specify which nodes to run on and whether there's overlap with the hosts the CITGM jobs currently run on.

joaocgreis added a commit to JaneaSystems/build that referenced this issue Dec 19, 2019
@joaocgreis
Copy link
Member

Installed CMake on all Windows machines (included in PR #2099).

joaocgreis added a commit that referenced this issue Jan 2, 2020
Refs: #2097
PR-URL: #2099
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
@BridgeAR
Copy link
Member Author

What's the status here?

@AshCripps
Copy link
Member

cmake should now be available on all test macs

@richardlau
Copy link
Member

cmake is now on the IBM platforms in the CI (we're using cmake to build libuv).

@github-actions
Copy link

github-actions bot commented May 6, 2021

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label May 6, 2021
@github-actions github-actions bot closed this as completed Jun 5, 2021
@bl-ue
Copy link

bl-ue commented Jun 5, 2021

Stable bots don't seem all that useful 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants