Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL certificate issues #233

Closed
jbergstroem opened this issue Nov 2, 2015 · 18 comments
Closed

SSL certificate issues #233

jbergstroem opened this issue Nov 2, 2015 · 18 comments

Comments

@jbergstroem
Copy link
Member

A few people have reported issues regarding to ssl certificates. I triaged it to lacking SNI support. According to Wikipedia the only client that seems remotely close would be wget, with the first supported release roughly three years ago (unless some distros compile clients specifically without certain features of x509).

The way to solve this is adding an additional IP for each SSL host we use (which in practise would mean one for iojs and one for nodejs) or moving SSL termination to Cloudflare which would require us to upgrade to a pro or business account.

I'm not sure how widespread this issue is, but either of above solution should be pretty easy to implement.

@Starefossen
Copy link
Member

Here is the SSL Server Test report for nodejs.org, at least on the browser side of things almost all of them support SNI.

Also, I am pretty sure that, if configured correctly, non-SNI capable clients will be able to connect to the default vhost.

@jbergstroem
Copy link
Member Author

connecting to the default vhost won't help them since that would return the wrong certificate for iojs.org (*.nodejs.org)

@jbergstroem
Copy link
Member Author

It looks like the vm's at travis-ci.org seems to have a too old version of wget.

@ljharb
Copy link
Member

ljharb commented Nov 2, 2015

This issue affects all travis-ci VMs that aren't in their new "container" format (ie, sudo: false is the new one) - and it may indeed affect the new ones also, but I haven't checked.

@Starefossen
Copy link
Member

So the issue is somewhat limited to old wget-users downloading io.js binaries? Mostly through travis ci which there apparently exists a workaround for?

@jbergstroem
Copy link
Member Author

That'd be my conclusion based on wikipedia. We for instance have this issue on our centos5 slaves; but again limited to wget.

@rvagg
Copy link
Member

rvagg commented Nov 3, 2015

I've just tried out the new "Floating IP" DO feature on the web server, it now has 45.55.98.129 pointing to it, but the server doesn't appear to be aware of this, it's obviously just a datacenter routing thing rather than going all the way down to the server like it can with AWS. So I'm not sure we're going to be able to do the separate IP thing unless we have a separate server which is a pain since we've gone through the process of integrating everything.

@jbergstroem
Copy link
Member Author

@rvagg doesn't that just mean we can assign another ip with network setup? I can try.

@rvagg
Copy link
Member

rvagg commented Nov 3, 2015

you can try I guess, I have left it on there for this kind of tinkering

@jbergstroem
Copy link
Member Author

So, the anchor ip you set up locally is where we want to point iojs (or nodejs, but i prefer messing up the prior). Not sure how to automate all of this ansible though. I'll look at that first.

@jbergstroem
Copy link
Member Author

OK, this likely needs to happen:

  1. cloudflare: upgrade iojs.org to a business account and upload the certificate
  2. cloudflare: change iojs.org to listen at the anchor public ip address
  3. nginx: make iojs listen at the internal anchor address
  4. (probably optional) nginx: make nodejs listen at the default public address

@rvagg
Copy link
Member

rvagg commented Nov 30, 2015

I recently downgraded iojs.org to a personal account because I discovered that my personal credit card was being charged $200/month for the pleasure of it being a business account...

@ljharb
Copy link
Member

ljharb commented Nov 30, 2015

@rvagg how recently? Perhaps that's what triggered these SSL issues.

@rvagg
Copy link
Member

rvagg commented Nov 30, 2015

pretty sure it's unrelated, we didn't lose any features that we were using as far as I know

@jbergstroem
Copy link
Member Author

As far as i know, going from business to free or using business won't affect SNI. What we need is an enterprise account to get our own ip.

@ljharb
Copy link
Member

ljharb commented Dec 1, 2015

ah, gotcha

@Trott
Copy link
Member

Trott commented Mar 30, 2018

@nodejs/build @jbergstroem Should this remain open?

@sam-github
Copy link
Contributor

Closing as stale, but if anyone wants to take this up feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants